win: Save contents of PEB to minidump

minidump/minidump_file_writer_test.cc

Index: minidump/minidump_file_writer_test.cc
diff --git a/minidump/minidump_file_writer_test.cc b/minidump/minidump_file_writer_test.cc
index 147d5c8a0b3c7937e915af8030a0107c5cc41c46..98911cc19ff69c2e67f6a396e0c1bf971f84a416 100644
--- a/minidump/minidump_file_writer_test.cc
+++ b/minidump/minidump_file_writer_test.cc
@@ -28,6 +28,7 @@
 #include "minidump/test/minidump_writable_test_util.h"
 #include "snapshot/test/test_cpu_context.h"
 #include "snapshot/test/test_exception_snapshot.h"
+#include "snapshot/test/test_memory_snapshot.h"
 #include "snapshot/test/test_module_snapshot.h"
 #include "snapshot/test/test_process_snapshot.h"
 #include "snapshot/test/test_system_snapshot.h"
@@ -252,6 +253,12 @@ TEST(MinidumpFileWriter, InitializeFromSnapshot_Basic) {
   system_snapshot->SetOperatingSystem(SystemSnapshot::kOperatingSystemMacOSX);
   process_snapshot.SetSystem(system_snapshot.Pass());
 
+  auto peb_snapshot = make_scoped_ptr(new TestMemorySnapshot());
+  peb_snapshot->SetAddress(0x07f90000);
+  peb_snapshot->SetSize(0x280);
+  peb_snapshot->SetValue('p');
+  process_snapshot.SetPeb(peb_snapshot.Pass());

[Mark Mentovai, 2015/09/23 21:40:50]

You never test that this had any effect on the output. Do you want to examine
the memory stream to make sure that it’s got this?

[scottmg, 2015/09/24 20:00:10]

Oops, done.

+
   MinidumpFileWriter minidump_file_writer;
   minidump_file_writer.InitializeFromSnapshot(&process_snapshot);