Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: minidump/minidump_file_writer.cc

Issue 1364053002: win: Save contents of PEB to minidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@save-teb
Patch Set: test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | minidump/minidump_file_writer_test.cc » ('j') | minidump/minidump_file_writer_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_file_writer.cc
diff --git a/minidump/minidump_file_writer.cc b/minidump/minidump_file_writer.cc
index 3d321c0b33553a98407205aaa27ee404acd256cf..fd1f795575952f996538c9d1a91db300afbb80f3 100644
--- a/minidump/minidump_file_writer.cc
+++ b/minidump/minidump_file_writer.cc
@@ -79,6 +79,13 @@ void MinidumpFileWriter::InitializeFromSnapshot(
&thread_id_map);
AddStream(thread_list.Pass());
+ auto peb = process_snapshot->Peb();
+ if (peb) {
+ std::vector<const MemorySnapshot*> peb_vector;
Mark Mentovai 2015/09/23 21:40:50 Use the (1, peb) constructor and skip the push_bac
scottmg 2015/09/24 20:00:10 Gone now that ExtraMemory() directly returns a vec
+ peb_vector.push_back(peb);
+ memory_list->AddFromSnapshot(peb_vector);
+ }
+
const ExceptionSnapshot* exception_snapshot = process_snapshot->Exception();
if (exception_snapshot) {
auto exception = make_scoped_ptr(new MinidumpExceptionWriter());
« no previous file with comments | « no previous file | minidump/minidump_file_writer_test.cc » ('j') | minidump/minidump_file_writer_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698