win: Save contents of PEB to minidump

snapshot/process_snapshot.h

Index: snapshot/process_snapshot.h
diff --git a/snapshot/process_snapshot.h b/snapshot/process_snapshot.h
index 42df05c9b21cf8d6c39ac7197a0fd117264f6bd5..a82b21a2b3d0b02367a751dc767de4997db051a6 100644
--- a/snapshot/process_snapshot.h
+++ b/snapshot/process_snapshot.h
@@ -27,6 +27,7 @@
 namespace crashpad {
 
 class ExceptionSnapshot;
+class MemorySnapshot;
 class ModuleSnapshot;
 class SystemSnapshot;
 class ThreadSnapshot;
@@ -160,6 +161,15 @@ class ProcessSnapshot {
   //!     object that it was obtained from. If the snapshot is not a result of
   //!     an exception, returns `nullptr`.
   virtual const ExceptionSnapshot* Exception() const = 0;
+
+  //! \brief Returns a vector of additional memory blocks that should be
+  //!     included in a minidump.
+  //!
+  //! \return An std::vector<const MemorySnapshot*> that will be included in the

[Mark Mentovai, 2015/09/25 17:05:34]

A, not an. Or for the comment, English is OK, so “A vector of MemorySnapshot
objects that will…”

[scottmg, 2015/09/25 17:29:31]

Really? :) I say "An ess tee dee vector..." when I'm reading that, so "A" sounds
awkward. I'll judo that with just "A vector..." though.

[Mark Mentovai, 2015/09/25 17:32:32]

scottmg wrote:
Heh. “ess tee dee” has a different meaning to me when you spell it out like
that. I say “standard.”

+  //!     crash dump. Ownership of the  pointers in the vector are not

[Mark Mentovai, 2015/09/25 17:05:34]

is not transferred, there’s only one ownership. Or borrow from the comments for
other similar things like Threads() and Modules().

[Mark Mentovai, 2015/09/25 17:05:35]

Two spaces between the and pointers.

[scottmg, 2015/09/25 17:29:31]

Oops, done.

[scottmg, 2015/09/25 17:29:31]

Done.

+  //!     transferred to the caller, they are scoped to the lifetime of the
+  //!     ProcessSnapshot object that they were obtained from.
+  virtual std::vector<const MemorySnapshot*> ExtraMemory() const = 0;
 };
 
 }  // namespace crashpad