win: Save contents of PEB to minidump

snapshot/process_snapshot.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #ifndef CRASHPAD_SNAPSHOT_PROCESS_SNAPSHOT_H_
 #define CRASHPAD_SNAPSHOT_PROCESS_SNAPSHOT_H_
 
 #include <sys/time.h>
 #include <sys/types.h>
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "util/misc/uuid.h"
 
 namespace crashpad {
 
 class ExceptionSnapshot;
+class MemorySnapshot;
 class ModuleSnapshot;
 class SystemSnapshot;
 class ThreadSnapshot;
 
 //! \brief An abstract interface to a snapshot representing the state of a
 //!     process.
 //!
 //! This is the top-level object in a family of Snapshot objects, because it
 //! gives access to a SystemSnapshot, vectors of ModuleSnapshot and
 //! ThreadSnapshot objects, and possibly an ExceptionSnapshot. In turn,
@@ skipping 113 matching lines @@
   virtual std::vector<const ThreadSnapshot*> Threads() const = 0;
 
   //! \brief Returns an ExceptionSnapshot reflecting the exception that the
   //!     snapshot process sustained to trigger the snapshot being taken.
   //!
   //! \return An ExceptionSnapshot object. The caller does not take ownership of
   //!     this object, it is scoped to the lifetime of the ProcessSnapshot
   //!     object that it was obtained from. If the snapshot is not a result of
   //!     an exception, returns `nullptr`.
   virtual const ExceptionSnapshot* Exception() const = 0;
+
+  //! \brief Returns a vector of additional memory blocks that should be
+  //!     included in a minidump.
+  //!
+  //! \return An std::vector<const MemorySnapshot*> that will be included in the

[Mark Mentovai, 2015/09/25 17:05:34]

A, not an. Or for the comment, English is OK, so “A vector of MemorySnapshot
objects that will…”

[scottmg, 2015/09/25 17:29:31]

Really? :) I say "An ess tee dee vector..." when I'm reading that, so "A" sounds
awkward. I'll judo that with just "A vector..." though.

[Mark Mentovai, 2015/09/25 17:32:32]

scottmg wrote:
Heh. “ess tee dee” has a different meaning to me when you spell it out like
that. I say “standard.”

+  //!     crash dump. Ownership of the  pointers in the vector are not

[Mark Mentovai, 2015/09/25 17:05:34]

is not transferred, there’s only one ownership. Or borrow from the comments for
other similar things like Threads() and Modules().

[Mark Mentovai, 2015/09/25 17:05:35]

Two spaces between the and pointers.

[scottmg, 2015/09/25 17:29:31]

Oops, done.

[scottmg, 2015/09/25 17:29:31]

Done.

+  //!     transferred to the caller, they are scoped to the lifetime of the
+  //!     ProcessSnapshot object that they were obtained from.
+  virtual std::vector<const MemorySnapshot*> ExtraMemory() const = 0;
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_SNAPSHOT_PROCESS_SNAPSHOT_H_