Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136403005: Remove CALL_AS_FUNCTION and CALL_AS_METHOD. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest
Modified:
6 years, 11 months ago
Reviewers:
dcarney, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Remove CALL_AS_FUNCTION and CALL_AS_METHOD. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18590

Patch Set 1 #

Total comments: 1

Patch Set 2 : Port to x64 #

Patch Set 3 : ARM port #

Patch Set 4 : Don't store/restore ecx/rcx/r5 given that it doesn't contain callkind anymore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -420 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 9 chunks +9 lines, -21 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 5 chunks +2 lines, -10 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M src/arm/ic-arm.cc View 1 2 2 chunks +2 lines, -10 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 8 chunks +3 lines, -13 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 2 chunks +6 lines, -17 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 13 chunks +11 lines, -39 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M src/ast.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ast.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 6 chunks +6 lines, -18 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 9 chunks +5 lines, -20 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 5 chunks +2 lines, -10 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 3 chunks +1 line, -6 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 8 chunks +3 lines, -13 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +8 lines, -20 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 13 chunks +12 lines, -41 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/stub-cache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/type-info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/typing.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/v8globals.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 9 chunks +5 lines, -21 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 5 chunks +2 lines, -10 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M src/x64/ic-x64.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 8 chunks +3 lines, -13 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 chunks +6 lines, -17 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 12 chunks +12 lines, -40 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
6 years, 11 months ago (2014-01-13 17:51:42 UTC) #1
dcarney
lgtm https://codereview.chromium.org/136403005/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/136403005/diff/1/src/ia32/code-stubs-ia32.cc#newcode2553 src/ia32/code-stubs-ia32.cc:2553: if (ReceiverMightBeImplicit()) { this block can be removed
6 years, 11 months ago (2014-01-13 18:39:34 UTC) #2
Toon Verwaest
Added platform ports. Please take another look.
6 years, 11 months ago (2014-01-14 13:39:21 UTC) #3
dcarney
lgtm
6 years, 11 months ago (2014-01-14 13:58:29 UTC) #4
Toon Verwaest
6 years, 11 months ago (2014-01-14 14:36:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r18590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698