Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: src/typing.cc

Issue 136403005: Remove CALL_AS_FUNCTION and CALL_AS_METHOD. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Don't store/restore ecx/rcx/r5 given that it doesn't contain callkind anymore Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/type-info.cc ('k') | src/v8globals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 } 523 }
524 524
525 RECURSE(Visit(expr->obj())); 525 RECURSE(Visit(expr->obj()));
526 RECURSE(Visit(expr->key())); 526 RECURSE(Visit(expr->key()));
527 527
528 // We don't know anything about the result type. 528 // We don't know anything about the result type.
529 } 529 }
530 530
531 531
532 void AstTyper::VisitCall(Call* expr) { 532 void AstTyper::VisitCall(Call* expr) {
533 // Collect type feedback.
534 Expression* callee = expr->expression(); 533 Expression* callee = expr->expression();
535 Property* prop = callee->AsProperty(); 534 Property* prop = callee->AsProperty();
536 if (prop != NULL) { 535 ContextualMode contextual_mode = prop == NULL ? CONTEXTUAL : NOT_CONTEXTUAL;
537 expr->RecordTypeFeedback(oracle(), CALL_AS_METHOD); 536 // Collect type feedback.
538 } else { 537 expr->RecordTypeFeedback(oracle(), contextual_mode);
539 expr->RecordTypeFeedback(oracle(), CALL_AS_FUNCTION);
540 }
541 538
542 RECURSE(Visit(expr->expression())); 539 RECURSE(Visit(expr->expression()));
543 ZoneList<Expression*>* args = expr->arguments(); 540 ZoneList<Expression*>* args = expr->arguments();
544 for (int i = 0; i < args->length(); ++i) { 541 for (int i = 0; i < args->length(); ++i) {
545 Expression* arg = args->at(i); 542 Expression* arg = args->at(i);
546 RECURSE(Visit(arg)); 543 RECURSE(Visit(arg));
547 } 544 }
548 545
549 VariableProxy* proxy = expr->expression()->AsVariableProxy(); 546 VariableProxy* proxy = expr->expression()->AsVariableProxy();
550 if (proxy != NULL && proxy->var()->is_possibly_eval(isolate())) { 547 if (proxy != NULL && proxy->var()->is_possibly_eval(isolate())) {
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 792 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
796 } 793 }
797 794
798 795
799 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 796 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
800 RECURSE(Visit(stmt->body())); 797 RECURSE(Visit(stmt->body()));
801 } 798 }
802 799
803 800
804 } } // namespace v8::internal 801 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/type-info.cc ('k') | src/v8globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698