Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 136403004: Allocate memory in SkTDynamicHash on first use. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
Tom Hudson, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Allocate memory in SkTDynamicHash on first use. This eliminates any dynamic allocation for hash tables that are never used. This helps SkPicture, where some tables (SkPaint) are almost always used, but some rarely (SkMatrix) or never (SkRegion). This also removes the (as yet unimportant) ability for the hash table to shrink. This makes resizing harder to reason about, so I'd like to leave it out until we see a need. BUG=skia:1850 Committed: http://code.google.com/p/skia/source/detail?r=13051

Patch Set 1 #

Patch Set 2 : add missing this #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -44 lines) Patch
M src/core/SkTDynamicHash.h View 1 7 chunks +14 lines, -37 lines 0 comments Download
M tests/DynamicHashTest.cpp View 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
hashes drop off the null-picture-record profile, as hoped.
6 years, 11 months ago (2014-01-13 17:15:47 UTC) #1
reed1
1. is it possible to just create a new hash efficiently from an existing one... ...
6 years, 11 months ago (2014-01-13 17:38:04 UTC) #2
mtklein
On 2014/01/13 17:38:04, reed1 wrote: > 1. is it possible to just create a new ...
6 years, 11 months ago (2014-01-13 17:43:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/136403004/30001
6 years, 11 months ago (2014-01-13 17:49:56 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 18:28:17 UTC) #5
Message was sent while issue was closed.
Change committed as 13051

Powered by Google App Engine
This is Rietveld 408576698