pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart - Issue 1363993004: Report info messages together with their error, warning, or hint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

Issue 1363993004: Report info messages together with their error, warning, or hint. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comment. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

index 78859405fceebe3a7ce8dbc9d186101c11665412..8c9f24783129663857d57171a2125aa9e7a07ec6 100644

--- a/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart

@@ -211,7 +211,8 @@ class ModelEmitter {

if (backend.requiresPreamble &&

!backend.htmlLibraryIsLoaded) {

- compiler.reportHint(NO_LOCATION_SPANNABLE, MessageKind.PREAMBLE);

+ compiler.reportHintMessage(

+ NO_LOCATION_SPANNABLE, MessageKind.PREAMBLE);

}

if (compiler.deferredMapUri != null) {

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart ('k') | pkg/compiler/lib/src/library_loader.dart » ('j') | no next file with comments »