Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1363943002: Revert of [Extensions Toolbar] Add a finch config for the redesign (Closed)

Created:
5 years, 3 months ago by huangs
Modified:
5 years, 3 months ago
Reviewers:
Finnur, Devlin, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions Toolbar] Add a finch config for the redesign (patchset #2 id:60001 of https://codereview.chromium.org/1363463002/ ) Reason for revert: This is causing time out for XP Tests: browser_tests: DeclarativeContentApiTest.ShowPageActionWithoutPageAction. Original issue's description: > [Extensions Toolbar] Add a finch config for the redesign > > Add an entry in field trials for the extension action redesign, and > fix any tests that fail with it as a default. > > BUG=533101 > TBR=avi@chromium.org for micro cocoa change > > Committed: https://crrev.com/ca056fb34f9003262f28061856042ed87ed865c4 > Cr-Commit-Position: refs/heads/master@{#350296} TBR=finnur@chromium.org,thakis@chromium.org,rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=533101 Committed: https://crrev.com/c059a0e8183000755ef106f5f74c029386cc7cfb Cr-Commit-Position: refs/heads/master@{#350341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -161 lines) Patch
M chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc View 2 chunks +20 lines, -54 lines 0 comments Download
M chrome/browser/extensions/extension_action.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 chunk +9 lines, -14 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 13 chunks +31 lines, -24 lines 0 comments Download
M chrome/browser/extensions/location_bar_controller.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/location_bar/location_bar_browsertest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc View 2 chunks +1 line, -18 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
huangs
Created Revert of [Extensions Toolbar] Add a finch config for the redesign
5 years, 3 months ago (2015-09-23 13:46:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363943002/1
5 years, 3 months ago (2015-09-23 13:48:04 UTC) #3
commit-bot: I haz the power
Failed to commit the patch.
5 years, 3 months ago (2015-09-23 14:02:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363943002/1
5 years, 3 months ago (2015-09-23 18:15:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 18:20:22 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 18:35:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c059a0e8183000755ef106f5f74c029386cc7cfb
Cr-Commit-Position: refs/heads/master@{#350341}

Powered by Google App Engine
This is Rietveld 408576698