Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 1363943002: Revert of [Extensions Toolbar] Add a finch config for the redesign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action.cc
diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc
index c6033e53f8fb2f48bf8ddb7643f433af4945d6ed..af9e8685934c872f5e0e5b4aa3cdab328156bc93 100644
--- a/chrome/browser/extensions/extension_action.cc
+++ b/chrome/browser/extensions/extension_action.cc
@@ -256,20 +256,15 @@
if (default_icon_image_)
return default_icon_image_->image();
- if (placeholder_icon_image_.IsEmpty()) {
- // If the extension action redesign is enabled, we use a special placeholder
- // icon (with the first letter of the extension name) rather than the
- // default (puzzle piece).
- if (extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()) {
- placeholder_icon_image_ =
- extensions::ExtensionIconPlaceholder::CreateImage(
- extension_misc::EXTENSION_ICON_ACTION, extension_name_);
- } else {
- placeholder_icon_image_ = GetDefaultIcon();
- }
- }
-
- return placeholder_icon_image_;
+ // If the extension action redesign is enabled, we use a special placeholder
+ // icon (with the first letter of the extension name) rather than the default
+ // (puzzle piece).
+ if (extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()) {
+ return extensions::ExtensionIconPlaceholder::CreateImage(
+ extension_misc::EXTENSION_ICON_ACTION, extension_name_);
+ }
+
+ return GetDefaultIcon();
}
bool ExtensionAction::HasPopupUrl(int tab_id) const {
« no previous file with comments | « chrome/browser/extensions/extension_action.h ('k') | chrome/browser/extensions/lazy_background_page_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698