Remove SkBitmapSource

Remove SkBitmapSource

To avoid breaking existing SKPs, add a deserialization stub which
unflattens SkBitmapSource records to SkImageSources.

R=reed@google.com,mtklein@google.com,robertphillips@google.com

Committed: https://skia.googlesource.com/skia/+/2f5891ea6460675b3c8d08684e1fa8b239bc0a14

[f(malita), 2015-09-23 12:27:37]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 12:27:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363913002/1

[f(malita), 2015-09-23 12:29:49]

fmalita@chromium.org changed reviewers:
+ tomhudson@chromium.org

[f(malita), 2015-09-23 12:31:08]

Blink/Chromium have been converted to SkImageSource.

I don't think this is used by Android at all - Tom, can you confirm?

[tomhudson, 2015-09-23 13:30:37]

https://cs.corp.google.com/#android/ doesn't have any hits for SkBitmapSource
outside of external/skia/, so if it's used it's used indirectly.

[tomhudson, 2015-09-23 13:46:33]

tomhudson@google.com changed reviewers:
+ tomhudson@google.com

[tomhudson, 2015-09-23 13:46:33]

lgtm

https://codereview.chromium.org/1363913002/diff/1/gm/imagefilterstransformed.cpp
File gm/imagefilterstransformed.cpp (right):

https://codereview.chromium.org/1363913002/diff/1/gm/imagefilterstransformed....
gm/imagefilterstransformed.cpp:97: static SkImage* MakeGradientCircle(int width,
int height) {
Nit: we could move this outside the class now, although I suspect the official
style guide is silent about whether we *ought*?

[f(malita), 2015-09-23 14:11:11]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[f(malita), 2015-09-23 14:11:16]

https://codereview.chromium.org/1363913002/diff/1/gm/imagefilterstransformed.cpp
File gm/imagefilterstransformed.cpp (right):

https://codereview.chromium.org/1363913002/diff/1/gm/imagefilterstransformed....
gm/imagefilterstransformed.cpp:97: static SkImage* MakeGradientCircle(int width,
int height) {
On 2015/09/23 13:46:33, tomhudson wrote:
> Nit: we could move this outside the class now, although I suspect the official
> style guide is silent about whether we *ought*?

Done.

[commit-bot: I haz the power, 2015-09-23 14:11:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363913002/20001

[commit-bot: I haz the power, 2015-09-23 18:35:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 18:35:51]

Dry run: This issue passed the CQ dry run.

[f(malita), 2015-09-24 21:35:16]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-09-24 21:35:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1363913002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2015-09-24 21:35:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363913002/20001

[commit-bot: I haz the power, 2015-09-24 21:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 21:36:54]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[f(malita), 2015-09-24 21:37:50]

On 2015/09/24 21:36:54, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
>
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

Seeking public API benediction.

[reed1, 2015-09-25 08:30:08]

https://codereview.chromium.org/1363913002/diff/20001/src/utils/SkBitmapSourc...
File src/utils/SkBitmapSourceDeserializer.cpp (right):

https://codereview.chromium.org/1363913002/diff/20001/src/utils/SkBitmapSourc...
src/utils/SkBitmapSourceDeserializer.cpp:30: SkAutoTUnref<SkImage>
image(SkImage::NewFromBitmap(bitmap));
1. do we want to mark the bitmap as immutable before making the image?
2. I wonder if we can write buffer.readBitmapAsImage() to convert serialized
bitmaps into images in one-shot?

[f(malita), 2015-09-25 13:32:00]

https://codereview.chromium.org/1363913002/diff/20001/src/utils/SkBitmapSourc...
File src/utils/SkBitmapSourceDeserializer.cpp (right):

https://codereview.chromium.org/1363913002/diff/20001/src/utils/SkBitmapSourc...
src/utils/SkBitmapSourceDeserializer.cpp:30: SkAutoTUnref<SkImage>
image(SkImage::NewFromBitmap(bitmap));
On 2015/09/25 08:30:08, reed1 wrote:
> 1. do we want to mark the bitmap as immutable before making the image?

Good catch, will do.

> 2. I wonder if we can write buffer.readBitmapAsImage() to convert serialized
> bitmaps into images in one-shot?

Is there any benefit to that over SkImage::NewFromBitmap(bitmap)? (if the bitmap
is immutable we share the pixels, right?)

[robertphillips, 2015-09-25 15:35:50]

lgtm % Mike's comments

[f(malita), 2015-09-25 15:50:20]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-25 15:50:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363913002/40001

[f(malita), 2015-09-25 15:50:39]

On 2015/09/25 13:32:00, f(malita) wrote:
>
https://codereview.chromium.org/1363913002/diff/20001/src/utils/SkBitmapSourc...
> File src/utils/SkBitmapSourceDeserializer.cpp (right):
> 
>
https://codereview.chromium.org/1363913002/diff/20001/src/utils/SkBitmapSourc...
> src/utils/SkBitmapSourceDeserializer.cpp:30: SkAutoTUnref<SkImage>
> image(SkImage::NewFromBitmap(bitmap));
> On 2015/09/25 08:30:08, reed1 wrote:
> > 1. do we want to mark the bitmap as immutable before making the image?
> 
> Good catch, will do.

Done.

[commit-bot: I haz the power, 2015-09-25 15:55:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 15:55:18]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-09-25 16:14:58]

lgtm

[f(malita), 2015-09-25 16:14:59]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-09-25 16:14:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1363913002/#ps40001
(title: "immutable bitmap")

[commit-bot: I haz the power, 2015-09-25 16:15:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363913002/40001

[commit-bot: I haz the power, 2015-09-25 16:16:00]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2f5891ea6460675b3c8d08684e1fa8b239bc0a14