Remove SkBitmapSource

src/utils/SkBitmapSourceDeserializer.cpp

+/*
+ * Copyright 2015 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "SkBitmapSourceDeserializer.h"
+
+#include "SkBitmap.h"
+#include "SkFilterQuality.h"
+#include "SkImage.h"
+#include "SkImageSource.h"
+#include "SkReadBuffer.h"
+
+SkFlattenable* SkBitmapSourceDeserializer::CreateProc(SkReadBuffer& buffer) {
+    SkFilterQuality filterQuality;
+    if (buffer.isVersionLT(SkReadBuffer::kBitmapSourceFilterQuality_Version)) {
+        filterQuality = kHigh_SkFilterQuality;
+    } else {
+        filterQuality = (SkFilterQuality)buffer.readInt();
+    }
+    SkRect src, dst;
+    buffer.readRect(&src);
+    buffer.readRect(&dst);
+    SkBitmap bitmap;
+    if (!buffer.readBitmap(&bitmap)) {
+        return nullptr;
+    }
+    SkAutoTUnref<SkImage> image(SkImage::NewFromBitmap(bitmap));

[reed1, 2015/09/25 08:30:08]

1. do we want to mark the bitmap as immutable before making the image?
2. I wonder if we can write buffer.readBitmapAsImage() to convert serialized
bitmaps into images in one-shot?

[f(malita), 2015/09/25 13:31:59]

Good catch, will do.
Is there any benefit to that over SkImage::NewFromBitmap(bitmap)? (if the bitmap
is immutable we share the pixels, right?)

+
+    return SkImageSource::Create(image, src, dst, filterQuality);
+}