Issue 13639002: Adding force-wave-audio command line flag on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13639002: Adding force-wave-audio command line flag on Windows (Closed)

Created:
7 years, 8 months ago by henrika (OOO until Aug 14)

Modified:
7 years, 8 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Adding force-wave-audio flag on Windows. BUG=180591 TEST=misc audio clients in Chrome using the new --force-wave-audio flag on Win7 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192509

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -0 lines)			Patch
M	media/audio/win/core_audio_util_win.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	media/base/media_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/base/media_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

henrika (OOO until Aug 14)

Dale, I named the flag "--force-wave-audio" instead since it then allows us to change only ...

7 years, 8 months ago (2013-04-04 13:23:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/13639002/1

7 years, 8 months ago (2013-04-04 14:58:32 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-04 16:32:58 UTC) #4

henrika (OOO until Aug 14)

7 years, 8 months ago (2013-04-05 05:54:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r192509.