Port the order_profiling GYP flag to GN

Port the order_profiling GYP flag to GN

BUG=531278
TEST=None

Committed: https://crrev.com/af5bc4359a2a571f8c3d1a9e65f3f0508cde40c6
Cr-Commit-Position: refs/heads/master@{#351359}

[pkotwicz, 2015-09-23 03:59:02]

pkotwicz@chromium.org changed reviewers:
+ agrieve@chromium.org

[pkotwicz, 2015-09-23 03:59:03]

Andrew, can you please take a look? This CL depends on
https://codereview.chromium.org/1366433004/

https://codereview.chromium.org/1363793002/diff/1/build/config/android/BUILD.gn
File build/config/android/BUILD.gn (right):

https://codereview.chromium.org/1363793002/diff/1/build/config/android/BUILD....
build/config/android/BUILD.gn:44: configs = []
The GN code to allow nested configs has already landed. A GN roll has not yet
occurred. See https://codereview.chromium.org/1341373002/ for details.

One annoying tidbit: configs do not add subconfigs to the global config list.
This is why I am adding the "default_finstrument_functions" config in
BUILDCONFIG.gn instead of as a subconfig of the "compiler" config.

[agrieve, 2015-09-23 19:20:49]

Awesome approach!

https://codereview.chromium.org/1363793002/diff/20001/build/config/android/BU...
File build/config/android/BUILD.gn (right):

https://codereview.chromium.org/1363793002/diff/20001/build/config/android/BU...
build/config/android/BUILD.gn:43: config("default_finstrument_functions") {
"finstrument" is a bit of a funny word. Maybe just call it
"default_instrument_functions"

https://codereview.chromium.org/1363793002/diff/20001/build/config/android/BU...
build/config/android/BUILD.gn:44: configs = []
nit: remove the empty list initialization and use:

if (order_profiling) {
  configs = [ A ]
} eles {
  configs = [ B ]
}

https://codereview.chromium.org/1363793002/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1363793002/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:644: defines += [ "CYGPROFILE_INSTRUMENTATION=1"
]
Would be better to put this in the default_finstrument_functions config so that
when a target removes the config they don't have the define still being set
(plus it keeps it out of this catch-all file)

[pkotwicz, 2015-09-23 19:57:08]

Andrew, can you please take another look?

https://codereview.chromium.org/1363793002/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1363793002/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:644: defines += [ "CYGPROFILE_INSTRUMENTATION=1"
]
I moved this to the finstrument_functions config as you requested

[agrieve, 2015-09-23 20:11:03]

On 2015/09/23 19:57:08, pkotwicz wrote:
> Andrew, can you please take another look?
> 
>
https://codereview.chromium.org/1363793002/diff/20001/build/config/compiler/B...
> File build/config/compiler/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1363793002/diff/20001/build/config/compiler/B...
> build/config/compiler/BUILD.gn:644: defines += [
"CYGPROFILE_INSTRUMENTATION=1"
> ]
> I moved this to the finstrument_functions config as you requested

Looks great! lgtm

[agrieve, 2015-09-23 20:11:30]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[pkotwicz, 2015-09-23 20:37:19]

brettw@ can you please take a look?

This CL depends on the nested config ability that you are adding to GN

[pkotwicz, 2015-09-25 17:30:31]

brettw@ Ping!

[brettw, 2015-09-28 20:28:34]

Sorry for the delay. Thanks!

LGTM

https://codereview.chromium.org/1363793002/diff/40001/build/config/android/co...
File build/config/android/config.gni (right):

https://codereview.chromium.org/1363793002/diff/40001/build/config/android/co...
build/config/android/config.gni:75: order_profiling = false
Can you prefix this name with "is_" or "use_" so the boolean-ness of the flag is
more clear?

[pkotwicz, 2015-09-29 17:52:24]

Patchset #4 (id:60001) has been deleted

[pkotwicz, 2015-09-29 17:53:49]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-09-29 17:53:49]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/1363793002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-09-29 17:55:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363793002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363793002/80001

[commit-bot: I haz the power, 2015-09-29 18:31:44]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-09-29 18:33:00]

Patchset 4 (id:??) landed as
https://crrev.com/af5bc4359a2a571f8c3d1a9e65f3f0508cde40c6
Cr-Commit-Position: refs/heads/master@{#351359}