Port the order_profiling GYP flag to GN

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/toolchain/ccache.gni")
 
 if (current_cpu == "arm") {
@@ skipping 172 matching lines @@
       # TODO(phajdan.jr): Use -fstack-protector-strong when our gcc supports it.
       cflags += [ "--param=ssp-buffer-size=4" ]
       if (is_android && (current_cpu == "arm64" || current_cpu == "x86")) {
         cflags += [ "-fno-stack-protector" ]
       } else {
         cflags += [ "-fstack-protector" ]
       }
     }
 
     # Linker warnings.
-    if (!(is_chromeos && current_cpu == "arm") && !is_mac && !is_ios) {
+    if (!(is_chromeos && current_cpu == "arm") &&
+        !(is_android && order_profiling) && !is_mac && !is_ios) {
       # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
+      # TODO(azarchs): Fix link errors when linking with order_profiling=1
+      # crbug.com/485542
       ldflags += [ "-Wl,--fatal-warnings" ]
     }
 
     # Common options for AddressSanitizer, LeakSanitizer, ThreadSanitizer,
     # MemorySanitizer and non-official CFI builds.
     if (using_sanitizer || (is_cfi && !is_official_build)) {
       cflags += [
         "-fno-omit-frame-pointer",
         "-gline-tables-only",
       ]
@@ skipping 425 matching lines @@
       # TODO(eugenis): find a way to reenable this.
       cflags += [ "-mllvm -asan-globals=0" ]
     }
 
     defines += [ "ANDROID" ]
 
     # The NDK has these things, but doesn't define the constants
     # to say that it does. Define them here instead.
     defines += [ "HAVE_SYS_UIO_H" ]
 
+    if (order_profiling) {
+      defines += [ "CYGPROFILE_INSTRUMENTATION=1" ]

[agrieve, 2015/09/23 19:20:48]

Would be better to put this in the default_finstrument_functions config so that
when a target removes the config they don't have the define still being set
(plus it keeps it out of this catch-all file)

[pkotwicz, 2015/09/23 19:57:08]

I moved this to the finstrument_functions config as you requested

+    }
+
     # Use gold for Android for most CPU architectures.
     if (current_cpu == "x86" || current_cpu == "x64" || current_cpu == "arm") {
       ldflags += [ "-fuse-ld=gold" ]
       if (is_clang) {
         # Let clang find the ld.gold in the NDK.
         ldflags += [ "--gcc-toolchain=$rebased_android_toolchain_root" ]
       }
 
       # Use -mstackrealign due to a bug on ia32 Jelly Bean.
       # See crbug.com/521527
@@ skipping 852 matching lines @@
   } else if (symbol_level == 1) {
     cflags = minimal_symbols_cflags
     ldflags = minimal_symbols_ldflags
   } else if (symbol_level == 2) {
     cflags = symbols_cflags
     ldflags = symbols_ldflags
   } else {
     assert(false)
   }
 }