components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java - Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Ben's tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java ('k') | components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

index ebefa6b238a02a70fe6ef59e3f051cf706601711..2bbcca1f9efae979c903424c184e89476df1e383 100644

--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

@@ -13,7 +13,7 @@ import java.util.Map;

/**

* Network request using {@link java.net.HttpURLConnection}.

- * @deprecated Use {@link UrlRequestContext} instead.

+ * @deprecated Use {@link CronetEngine} instead.

@Deprecated

class HttpUrlConnectionUrlRequestFactory extends HttpUrlRequestFactory {

@@ -21,8 +21,7 @@ class HttpUrlConnectionUrlRequestFactory extends HttpUrlRequestFactory {

private final Context mContext;

private final String mDefaultUserAgent;

- public HttpUrlConnectionUrlRequestFactory(

- Context context, UrlRequestContextConfig config) {

+ public HttpUrlConnectionUrlRequestFactory(Context context, CronetEngine.Builder config) {

mContext = context;

String userAgent = config.userAgent();

if (userAgent.isEmpty()) {