Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Ben's tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
index cd4b710f7c710b296620ba6ed0e150261833bf48..7cdabde2cbeedb1146889c530901f0ca1fa571b8 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
@@ -4,7 +4,6 @@
package org.chromium.net;
-import android.content.Context;
import android.os.Build;
import android.os.ConditionVariable;
import android.os.Handler;
@@ -26,11 +25,11 @@ import java.util.concurrent.atomic.AtomicInteger;
import javax.annotation.concurrent.GuardedBy;
/**
- * UrlRequestContext using Chromium HTTP stack implementation.
+ * CronetEngine using Chromium HTTP stack implementation.
*/
@JNINamespace("cronet")
-@UsedByReflection("UrlRequestContext.java")
-class CronetUrlRequestContext extends UrlRequestContext {
+@UsedByReflection("CronetEngine.java")
+class CronetUrlRequestContext extends CronetEngine {
private static final int LOG_NONE = 3; // LOG(FATAL), no VLOG.
private static final int LOG_DEBUG = -1; // LOG(FATAL...INFO), VLOG(1)
private static final int LOG_VERBOSE = -2; // LOG(FATAL...INFO), VLOG(2)
@@ -62,12 +61,11 @@ class CronetUrlRequestContext extends UrlRequestContext {
private final ObserverList<NetworkQualityThroughputListener> mThroughputListenerList =
new ObserverList<NetworkQualityThroughputListener>();
- @UsedByReflection("UrlRequestContext.java")
- public CronetUrlRequestContext(Context context,
- UrlRequestContextConfig config) {
- CronetLibraryLoader.ensureInitialized(context, config);
+ @UsedByReflection("CronetEngine.java")
+ public CronetUrlRequestContext(CronetEngine.Builder builder) {
+ CronetLibraryLoader.ensureInitialized(builder.getContext(), builder);
nativeSetMinLogLevel(getLoggingLevel());
- mUrlRequestContextAdapter = nativeCreateRequestContextAdapter(config.toString());
+ mUrlRequestContextAdapter = nativeCreateRequestContextAdapter(builder.toString());
if (mUrlRequestContextAdapter == 0) {
throw new NullPointerException("Context Adapter creation failed.");
}
@@ -98,7 +96,7 @@ class CronetUrlRequestContext extends UrlRequestContext {
synchronized (mLock) {
checkHaveAdapter();
return new CronetUrlRequest(this, mUrlRequestContextAdapter, url,
- UrlRequest.REQUEST_PRIORITY_MEDIUM, listener, executor);
+ UrlRequest.Builder.REQUEST_PRIORITY_MEDIUM, listener, executor);
}
}
@@ -282,7 +280,7 @@ class CronetUrlRequestContext extends UrlRequestContext {
private void checkHaveAdapter() throws IllegalStateException {
if (!haveRequestContextAdapter()) {
- throw new IllegalStateException("Context is shut down.");
+ throw new IllegalStateException("Engine is shut down.");
}
}

Powered by Google App Engine
This is Rietveld 408576698