components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java - Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: null-check UrlRequest.Builder() Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java ('k') | components/cronet/android/java/src/org/chromium/net/CronetEngine.java » ('j') | components/cronet/android/java/src/org/chromium/net/CronetEngine.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

index 95200820ce3ea87e5861bc3f6cf53028d80731b0..897e925b26a95b4095b8b9f351409925b86e9ea3 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java

@@ -4,7 +4,6 @@

package org.chromium.net;

-import android.content.Context;

import android.os.Build;

import org.chromium.base.annotations.UsedByReflection;

@@ -22,15 +21,13 @@ public class ChromiumUrlRequestFactory extends HttpUrlRequestFactory {

private ChromiumUrlRequestContext mRequestContext;

@UsedByReflection("HttpUrlRequestFactory.java")

- public ChromiumUrlRequestFactory(

- Context context, UrlRequestContextConfig config) {

+ public ChromiumUrlRequestFactory(CronetEngine.Builder builder) {

if (isEnabled()) {

- String userAgent = config.userAgent();

+ String userAgent = builder.userAgent();

if (userAgent.isEmpty()) {

- userAgent = UserAgent.from(context);

+ userAgent = UserAgent.from(builder.getContext());

}

- mRequestContext = new ChromiumUrlRequestContext(context,

- userAgent, config);

+ mRequestContext = new ChromiumUrlRequestContext(userAgent, builder);

}