components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java - Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: null-check UrlRequest.Builder() Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/README.md ('k') | components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java » ('j') | components/cronet/android/java/src/org/chromium/net/CronetEngine.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

index 2901071a2babed3357c018c3e87c4332c102fd3f..ace67d570b5f3595cc948f7f549cc23e322fd424 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

@@ -4,7 +4,6 @@

package org.chromium.net;

-import android.content.Context;

import android.os.Handler;

import android.os.Looper;

import android.os.Process;

@@ -33,11 +32,10 @@ public class ChromiumUrlRequestContext {

/**

* Constructor.

- protected ChromiumUrlRequestContext(

- final Context context, String userAgent, UrlRequestContextConfig config) {

- CronetLibraryLoader.ensureInitialized(context, config);

+ protected ChromiumUrlRequestContext(String userAgent, CronetEngine.Builder builder) {

+ CronetLibraryLoader.ensureInitialized(builder);

mChromiumUrlRequestContextAdapter =

- nativeCreateRequestContextAdapter(userAgent, getLoggingLevel(), config.toString());

+ nativeCreateRequestContextAdapter(userAgent, getLoggingLevel(), builder.toString());

if (mChromiumUrlRequestContextAdapter == 0) {

throw new NullPointerException("Context Adapter creation failed");

}