Issue 1363643003: Fix more clang/win plugin warnings after GDI font emulation CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1363643003: Fix more clang/win plugin warnings after GDI font emulation CL. (Closed)

Created:
5 years, 3 months ago by Nico

Modified:
5 years, 3 months ago

Reviewers:
forshaw

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix more clang/win plugin warnings after GDI font emulation CL. BUG=523278 TBR=forshaw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/731e0ce568c52716b6040ad3317699f382f344a5

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	content/common/font_warmup_win_unittest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

should fix ..\..\content\common\font_warmup_win_unittest.cc(135,20) : error: [chromium-style] Overriding method must be marked with 'override' or 'final'. ...

5 years, 3 months ago (2015-09-23 03:24:01 UTC) #1

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/731e0ce568c52716b6040ad3317699f382f344a5 Cr-Commit-Position: refs/heads/master@{#350293}

5 years, 3 months ago (2015-09-23 03:25:58 UTC) #2

Nico

Committed patchset #1 (id:1) manually as 731e0ce568c52716b6040ad3317699f382f344a5 (presubmit successful).

5 years, 3 months ago (2015-09-23 03:26:19 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages