Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1363643002: [Android] Fix miscellaneous small issues with gtest platform mode. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, kjellander_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix miscellaneous small issues with gtest platform mode. BUG=428729, 534752, 534878 Committed: https://crrev.com/6323fa9ef794b98a98982acd3334a164802f7d2d Cr-Commit-Position: refs/heads/master@{#350405}

Patch Set 1 #

Patch Set 2 : fix nanos being handled as a float & being converted to "9+e11" #

Total comments: 2

Patch Set 3 : rnephew's comment + logs in regular output #

Patch Set 4 : browser test timeouts back up #

Patch Set 5 : rebase on blink #

Total comments: 1

Patch Set 6 : back out timeout changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -23 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 1 2 1 chunk +18 lines, -8 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 2 3 4 5 3 chunks +13 lines, -1 line 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 2 chunks +20 lines, -12 lines 0 comments Download
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
jbudorick
Missed unit_tests when moving NativeUnitTestActivity to its own process in https://codereview.chromium.org/1358593002 + better timeout and ...
5 years, 3 months ago (2015-09-22 20:38:25 UTC) #2
rnephew (Wrong account)
lgtm with question. https://codereview.chromium.org/1363643002/diff/20001/build/android/pylib/local/device/local_device_gtest_run.py File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/1363643002/diff/20001/build/android/pylib/local/device/local_device_gtest_run.py#newcode77 build/android/pylib/local/device/local_device_gtest_run.py:77: timeout = int(kwargs['timeout'] * _SECONDS_TO_NANOS) Any ...
5 years, 3 months ago (2015-09-22 23:00:04 UTC) #4
jbudorick
https://codereview.chromium.org/1363643002/diff/20001/build/android/pylib/local/device/local_device_gtest_run.py File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/1363643002/diff/20001/build/android/pylib/local/device/local_device_gtest_run.py#newcode77 build/android/pylib/local/device/local_device_gtest_run.py:77: timeout = int(kwargs['timeout'] * _SECONDS_TO_NANOS) On 2015/09/22 at 23:00:04, ...
5 years, 3 months ago (2015-09-22 23:37:47 UTC) #5
Ted C
lgtm
5 years, 3 months ago (2015-09-22 23:38:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363643002/40001
5 years, 3 months ago (2015-09-22 23:42:27 UTC) #9
jbudorick
https://codereview.chromium.org/1363643002/diff/80001/build/android/pylib/local/device/local_device_gtest_run.py File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/1363643002/diff/80001/build/android/pylib/local/device/local_device_gtest_run.py#newcode77 build/android/pylib/local/device/local_device_gtest_run.py:77: extras[_EXTRA_SHARD_NANO_TIMEOUT] = int( kjellander: this is the change that ...
5 years, 3 months ago (2015-09-23 20:36:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363643002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363643002/100001
5 years, 3 months ago (2015-09-23 21:38:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/117438)
5 years, 3 months ago (2015-09-23 21:57:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363643002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363643002/100001
5 years, 3 months ago (2015-09-23 22:54:36 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-24 00:16:12 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 00:35:03 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6323fa9ef794b98a98982acd3334a164802f7d2d
Cr-Commit-Position: refs/heads/master@{#350405}

Powered by Google App Engine
This is Rietveld 408576698