Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1358593002: [Android] Switch gtests to platform mode. (RELAND) (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch gtests to platform mode. (RELAND) BUG=428729 Committed: https://crrev.com/566592abb54a5cb8488c76e4a16858ca650f58f8 Cr-Commit-Position: refs/heads/master@{#349931}

Patch Set 1 : original #

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -306 lines) Patch
M build/android/pylib/base/test_run_factory.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 3 chunks +6 lines, -0 lines 0 comments Download
D build/android/pylib/gtest/local_device_gtest_run.py View 1 chunk +0 lines, -241 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 2 chunks +4 lines, -2 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 1 4 chunks +19 lines, -1 line 0 comments Download
A + build/android/pylib/local/device/local_device_gtest_run.py View 1 6 chunks +21 lines, -17 lines 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 1 3 chunks +30 lines, -15 lines 0 comments Download
M build/android/test_runner.py View 3 chunks +8 lines, -9 lines 0 comments Download
M testing/android/native_test/java/AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 1 2 chunks +9 lines, -2 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java View 1 5 chunks +11 lines, -15 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 3 months ago (2015-09-19 02:59:00 UTC) #2
rnephew (Wrong account)
On 2015/09/19 02:59:00, jbudorick wrote: lgtm
5 years, 3 months ago (2015-09-21 12:06:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358593002/20001
5 years, 3 months ago (2015-09-21 14:11:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 15:32:56 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 15:33:45 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/566592abb54a5cb8488c76e4a16858ca650f58f8
Cr-Commit-Position: refs/heads/master@{#349931}

Powered by Google App Engine
This is Rietveld 408576698