Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h

Issue 1363613002: Save previous paint offset in LayoutObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No union (many compilers don't allow constructors); Fix a typo perhaps caused by switching to combiā€¦ Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h
index 237c0343f117040809bad534e38e006be8a8d053..e4a0ab1f35d39d51ce278d56c312f4315719ca3f 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h
@@ -75,11 +75,6 @@ public:
bool paintOffsetWasInvalidated(DisplayItemClient) const;
#endif
- // Record a new paint offset.
- // TODO(pdr): Remove these once the paint offset cache is on LayoutObject.
- void recordPaintOffset(DisplayItemClient, const LayoutPoint&);
- bool paintOffsetIsUnchanged(DisplayItemClient, const LayoutPoint&) const;
-
// These methods are called during painting.
template <typename DisplayItemClass, typename... Args>
DisplayItemClass& createAndAppend(Args&&... args)
@@ -175,11 +170,6 @@ private:
void updateValidlyCachedClientsIfNeeded() const;
- // Update the recorded paint offsets to remove any items that no longer have
- // corresponding cached display items.
- // TODO(pdr): Remove this once the paint offset cache is on LayoutObject.
- void removeUnneededPaintOffsetEntries();
-
#ifndef NDEBUG
WTF::String displayItemsAsDebugString(const DisplayItems&) const;
#endif
@@ -233,13 +223,6 @@ private:
unsigned m_nextScope;
Vector<unsigned> m_scopeStack;
- // Cache of LayoutObject paint offsets.
- // TODO(pdr): This should be on LayoutObject itself and is only on the display
- // item list temporarily until paint invalidation for v2 frees up space on
- // LayoutObject.
- using PreviousPaintOffsets = HashMap<DisplayItemClient, LayoutPoint>;
- PreviousPaintOffsets m_previousPaintOffsets;
-
#if ENABLE(ASSERT)
// This is used to check duplicated ids during add(). We could also check during
// updatePaintList(), but checking during add() helps developer easily find where

Powered by Google App Engine
This is Rietveld 408576698