LayoutTests/paint/invalidation/spv2/multicol-as-paint-container.html - Issue 1363613002: Save previous paint offset in LayoutObject

Side by Side Diff: LayoutTests/paint/invalidation/spv2/multicol-as-paint-container.html

Issue 1363613002: Save previous paint offset in LayoutObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | Source/core/layout/LayoutObject.h » ('j') | Source/core/layout/LayoutObject.h » ('J')

OLD	NEW
1 <!-- Based on fast/repaint/multicol-as-paint-container.html -->	1 <!-- Based on fast/repaint/multicol-as-paint-container.html -->

2 <!DOCTYPE html>	2 <!DOCTYPE html>

3 <script src="resources/paint-invalidation-test.js"></script>	3 <script src="resources/paint-invalidation-test.js"></script>

4 <script>	4 <script>

5 onload = runPaintInvalidationTest;	5 onload = runPaintInvalidationTest;

6 window.expectedPaintInvalidationObjects = [	6 window.expectedPaintInvalidationObjects = [

7 "LayoutText #text",	7 "LayoutText #text",

8 "InlineTextBox 'Lorem ipsum'",	8 "InlineTextBox 'Lorem ipsum'",

9 "InlineTextBox 'dolor sit amet,'",	9 "InlineTextBox 'dolor sit amet,'",

10 "InlineTextBox 'consectetur'",	10 "InlineTextBox 'consectetur'",

11 "InlineTextBox 'adipiscing'",	11 "InlineTextBox 'adipiscing'",

12 "InlineTextBox 'elit. Fusce'",	12 "InlineTextBox 'elit. Fusce'",

13 "InlineTextBox 'varius, metus'",	13 "InlineTextBox 'varius, metus'",

14 "InlineTextBox 'eu fringilla'",	14 "InlineTextBox 'eu fringilla'",

15 "InlineTextBox 'pulvinar, ipsum'",	15 "InlineTextBox 'pulvinar, ipsum'",

16 "InlineTextBox 'sapien'",	16 "InlineTextBox 'sapien'",

17 "InlineTextBox 'ultricies arcu,'",	17 "InlineTextBox 'ultricies arcu,'",

18 "InlineTextBox 'non condimentum'",	18 "InlineTextBox 'non condimentum'",

19 "InlineTextBox 'quam est eu'",	19 "InlineTextBox 'quam est eu'",

20 "InlineTextBox 'purus. Ut nisl'",	20 "InlineTextBox 'purus. Ut nisl'",

21 "InlineTextBox 'libero,'",	21 "InlineTextBox 'libero,'",

22 "InlineTextBox 'suscipit ut leo'",	22 "InlineTextBox 'suscipit ut leo'",

23 "InlineTextBox 'eget, dapibus'",	23 "InlineTextBox 'eget, dapibus'",

24 "InlineTextBox 'ultrices dolor.'",	24 "InlineTextBox 'ultrices dolor.'",

25 "LayoutMultiColumnSet (anonymous)",	25 "LayoutMultiColumnSet (anonymous)",

	26 "InlineTextBox 'Lorem ipsum'",
	pdr. 2015/09/22 22:44:44 I wouldn't have expected diffs when spv2 is enable I wouldn't have expected diffs when spv2 is enabled... doesn't this mean a real behavior change has been introduced? Xianzhu 2015/09/23 18:43:18 Noticed a problem of paint offset caching of line Show quoted text On 2015/09/22 22:44:44, pdr wrote: > I wouldn't have expected diffs when spv2 is enabled... doesn't this mean a real > behavior change has been introduced? Noticed a problem of paint offset caching of line boxes: we don't have separate paint offset cache for each line box. Previous update of paint offset affects later line boxes. Reverted https://codereview.chromium.org/1340133003/ (paint offset for Inlineboxes). Now check paint offset change in BlockPainter and InlinePainter and invalidate descendant lineboxes when paint offset changes.
	27 "InlineTextBox 'ultricies arcu,'",

26 ];	28 ];

27 function paintInvalidationTest() {	29 function paintInvalidationTest() {

28 var target = document.getElementById('target');	30 var target = document.getElementById('target');

29 target.style.color = 'green';	31 target.style.color = 'green';

30 }	32 }

31 </script>	33 </script>

32 <div id="target" style="-webkit-columns:2; -webkit-backface-visibility:hidden; w idth:630px; font:20px/1 Ahem; color:red;">	34 <div id="target" style="-webkit-columns:2; -webkit-backface-visibility:hidden; w idth:630px; font:20px/1 Ahem; color:red;">

33 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce	35 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce

34 varius, metus eu fringilla pulvinar, ipsum sapien ultricies arcu,	36 varius, metus eu fringilla pulvinar, ipsum sapien ultricies arcu,

35 non condimentum quam est eu purus. Ut nisl libero, suscipit ut leo	37 non condimentum quam est eu purus. Ut nisl libero, suscipit ut leo

36 eget, dapibus ultrices dolor.	38 eget, dapibus ultrices dolor.

37 </div>	39 </div>

38 <p>All text above should be green.</p>	40 <p>All text above should be green.</p>

OLD	NEW