Paint offset caching/change-detection for InlineBoxes

Paint offset caching/change-detection for InlineBoxes

This ensures correct paint invalidation of InlineBoxes when the
container moves without layout. This will be useful when we disable
location-change detection during paint invalidation for slimming paint
v2.

BUG=508383
Committed: https://crrev.com/ba79d3eec77f61aa3d336600194b97e2ec95b8c4
git-svn-id: svn://svn.chromium.org/blink/trunk@202242 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Xianzhu, 2015-09-14 21:09:03]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2015-09-14 21:27:42]

Very nice!

https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
File Source/core/paint/LayoutObjectDrawingRecorder.h (right):

https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
Source/core/paint/LayoutObjectDrawingRecorder.h:84:
LayoutObjectDrawingRecorder(GraphicsContext& context, const InlineBox&
inlineBox, DisplayItem::Type displayItemType, const FloatRect& clip, const
LayoutPoint& paintOffset)
Can we use "const DisplayItemClientWrapper&" to avoid duplicating this logic?

If not, I really do not like templates, but this is one place where they may be
preferable because the paint offset logic will be getting more complex soon.

https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
Source/core/paint/LayoutObjectDrawingRecorder.h:99:
LayoutObjectDrawingRecorder(GraphicsContext& context, const InlineBox&
inlineBox, DisplayItem::Type displayItemType, const LayoutRect& clip, const
LayoutPoint& paintOffset)
Lets not add these overloaded ctors unless they are used.

[Xianzhu, 2015-09-14 21:43:43]

https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
File Source/core/paint/LayoutObjectDrawingRecorder.h (right):

https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
Source/core/paint/LayoutObjectDrawingRecorder.h:84:
LayoutObjectDrawingRecorder(GraphicsContext& context, const InlineBox&
inlineBox, DisplayItem::Type displayItemType, const FloatRect& clip, const
LayoutPoint& paintOffset)
On 2015/09/14 21:27:42, pdr wrote:
> Can we use "const DisplayItemClientWrapper&" to avoid duplicating this logic?
> 
> If not, I really do not like templates, but this is one place where they may
be
> preferable because the paint offset logic will be getting more complex soon.

There is a difference between the LayoutObject version and this version about
PaintInvalidationDelayedFull.

Extracted a private updatePaintOffsetIfNeeded() method.

https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
Source/core/paint/LayoutObjectDrawingRecorder.h:99:
LayoutObjectDrawingRecorder(GraphicsContext& context, const InlineBox&
inlineBox, DisplayItem::Type displayItemType, const LayoutRect& clip, const
LayoutPoint& paintOffset)
On 2015/09/14 21:27:42, pdr wrote:
> Lets not add these overloaded ctors unless they are used.

3 of the 4 constructors are used by painters, and the other 1 is used by the 3.

[pdr., 2015-09-14 22:12:49]

On 2015/09/14 at 21:43:43, wangxianzhu wrote:
>
https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
> File Source/core/paint/LayoutObjectDrawingRecorder.h (right):
> 
>
https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
> Source/core/paint/LayoutObjectDrawingRecorder.h:84:
LayoutObjectDrawingRecorder(GraphicsContext& context, const InlineBox&
inlineBox, DisplayItem::Type displayItemType, const FloatRect& clip, const
LayoutPoint& paintOffset)
> On 2015/09/14 21:27:42, pdr wrote:
> > Can we use "const DisplayItemClientWrapper&" to avoid duplicating this
logic?
> > 
> > If not, I really do not like templates, but this is one place where they may
be
> > preferable because the paint offset logic will be getting more complex soon.
> 
> There is a difference between the LayoutObject version and this version about
PaintInvalidationDelayedFull.
> 
> Extracted a private updatePaintOffsetIfNeeded() method.
> 
>
https://codereview.chromium.org/1340133003/diff/1/Source/core/paint/LayoutObj...
> Source/core/paint/LayoutObjectDrawingRecorder.h:99:
LayoutObjectDrawingRecorder(GraphicsContext& context, const InlineBox&
inlineBox, DisplayItem::Type displayItemType, const LayoutRect& clip, const
LayoutPoint& paintOffset)
> On 2015/09/14 21:27:42, pdr wrote:
> > Lets not add these overloaded ctors unless they are used.
> 
> 3 of the 4 constructors are used by painters, and the other 1 is used by the
3.

LGTM!

[Xianzhu, 2015-09-14 22:19:42]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-09-14 22:19:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340133003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340133003/20001

[commit-bot: I haz the power, 2015-09-15 01:07:08]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202242

[commit-bot: I haz the power, 2015-09-23 12:40:37]

Patchset 2 (id:??) landed as
https://crrev.com/ba79d3eec77f61aa3d336600194b97e2ec95b8c4