runtime/bin/stdio_patch.dart - Issue 13636003: Fix a number of issues with determining the type of stdio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/stdio_patch.dart

Issue 13636003: Fix a number of issues with determining the type of stdio (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/stdio_patch.dart

diff --git a/runtime/bin/stdio_patch.dart b/runtime/bin/stdio_patch.dart

index 38c488d1857070345f2796b21336caf916b4c378..941ae374af38f04c8c28d33354704039156be6bf 100644

--- a/runtime/bin/stdio_patch.dart

+++ b/runtime/bin/stdio_patch.dart

@@ -31,7 +31,11 @@ patch class _StdIOUtils {

}

static int _socketType(nativeSocket) {

- return _getSocketType(nativeSocket);

+ var result = _getSocketType(nativeSocket);

+ if (result is OSError) {

+ throw new FileIOException("Error retreiving socket type", result);

+ }

+ return result;

}

« no previous file with comments | « runtime/bin/socket_macos.cc ('k') | sdk/lib/io/stdio.dart » ('j') | no next file with comments »