Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: runtime/bin/stdio_patch.dart

Issue 13636003: Fix a number of issues with determining the type of stdio (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/socket_macos.cc ('k') | sdk/lib/io/stdio.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 patch class _StdIOUtils { 5 patch class _StdIOUtils {
6 static Stream<List<int>> _getStdioInputStream() { 6 static Stream<List<int>> _getStdioInputStream() {
7 switch (_getStdioHandleType(0)) { 7 switch (_getStdioHandleType(0)) {
8 case _STDIO_HANDLE_TYPE_TERMINAL: 8 case _STDIO_HANDLE_TYPE_TERMINAL:
9 case _STDIO_HANDLE_TYPE_PIPE: 9 case _STDIO_HANDLE_TYPE_PIPE:
10 case _STDIO_HANDLE_TYPE_SOCKET: 10 case _STDIO_HANDLE_TYPE_SOCKET:
(...skipping 13 matching lines...) Expand all
24 case _STDIO_HANDLE_TYPE_SOCKET: 24 case _STDIO_HANDLE_TYPE_SOCKET:
25 return new _Socket._writePipe(fd); 25 return new _Socket._writePipe(fd);
26 case _STDIO_HANDLE_TYPE_FILE: 26 case _STDIO_HANDLE_TYPE_FILE:
27 return new IOSink(new _FileStreamConsumer.fromStdio(fd)); 27 return new IOSink(new _FileStreamConsumer.fromStdio(fd));
28 default: 28 default:
29 throw new FileIOException("Unsupported stdin type"); 29 throw new FileIOException("Unsupported stdin type");
30 } 30 }
31 } 31 }
32 32
33 static int _socketType(nativeSocket) { 33 static int _socketType(nativeSocket) {
34 return _getSocketType(nativeSocket); 34 var result = _getSocketType(nativeSocket);
35 if (result is OSError) {
36 throw new FileIOException("Error retreiving socket type", result);
37 }
38 return result;
35 } 39 }
36 } 40 }
37 41
38 42
39 _getStdioHandle(_NativeSocket socket, int num) native "Socket_GetStdioHandle"; 43 _getStdioHandle(_NativeSocket socket, int num) native "Socket_GetStdioHandle";
40 _getStdioHandleType(int num) native "File_GetStdioHandleType"; 44 _getStdioHandleType(int num) native "File_GetStdioHandleType";
41 _getSocketType(_NativeSocket nativeSocket) native "Socket_GetType"; 45 _getSocketType(_NativeSocket nativeSocket) native "Socket_GetType";
OLDNEW
« no previous file with comments | « runtime/bin/socket_macos.cc ('k') | sdk/lib/io/stdio.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698