Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1363243002: win: Let reorder-imports.py fail if its invocation of swapimport.exe fails. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Let reorder-imports.py fail if its invocation of swapimport.exe fails. At first I didn't hook up the script correctly in the gn build. swapimport.exe printed ERROR:swapimport_app.cc(214)] Path does not exist: ../../chrome/initialexe\chrome.exe but that didn't make the build fail -- instead, it silently left the old chrome.exe (from prior builds) around. Make it so that swapimport.exe failing makes the build fail. BUG=505062, 512599 Committed: https://crrev.com/7c3c949a348b5f6e47eea84f5d533918d816fba4 Cr-Commit-Position: refs/heads/master@{#350482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/win/reorder-imports.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
whoops :-)
5 years, 3 months ago (2015-09-24 03:28:50 UTC) #2
robertshield
ick, that was a disaster waiting to happen.. thank goodness we had the unit test ...
5 years, 3 months ago (2015-09-24 03:34:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363243002/1
5 years, 3 months ago (2015-09-24 03:34:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 05:08:14 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 05:09:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c3c949a348b5f6e47eea84f5d533918d816fba4
Cr-Commit-Position: refs/heads/master@{#350482}

Powered by Google App Engine
This is Rietveld 408576698