build/win/reorder-imports.py - Issue 1363243002: win: Let reorder-imports.py fail if its invocation of swapimport.exe fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/win/reorder-imports.py

Issue 1363243002: win: Let reorder-imports.py fail if its invocation of swapimport.exe fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/win/reorder-imports.py

diff --git a/build/win/reorder-imports.py b/build/win/reorder-imports.py

index 281668fff5b457a363608a00865e5b285d94e417..00a69d75de373db3260cdf9fab2b6b911f24e6e9 100755

--- a/build/win/reorder-imports.py

+++ b/build/win/reorder-imports.py

@@ -31,7 +31,7 @@ def reorder_imports(input_dir, output_dir, architecture):

args.append('chrome_elf.dll');

- subprocess.call(args)

+ subprocess.check_call(args)

for fname in glob.iglob(os.path.join(input_dir, 'chrome.exe.*')):

shutil.copy(fname, os.path.join(output_dir, os.path.basename(fname)))

« no previous file with comments | « no previous file | no next file » | no next file with comments »