Issue 136313002: Revert of [SVG] Implement 'discard' element

Issue 136313002: Revert of [SVG] Implement 'discard' element (Closed)

Created:
6 years, 11 months ago by alph

Modified:
6 years, 11 months ago

Reviewers:
krit, f(malita), Inactive, pavane, pdr., Stephen Chennney, rwlbuis

CC:
blink-reviews, Steve Block, arv+blink, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, shans, f(malita), Inactive, darktears, pdr, rjwright, Stephen Chennney, Eric Willigers, dino_apple.com, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/99533004/ Reason for revert: svg/animations/discard-check-removal-order.html test is flaky TBR=dschulze@chromium.org,fmalita@chromium.org,pdr@chromium.org,schenney@chromium.org,rob.buis@samsung.com,ch.dumez@samsung.com,pavan.e@samsung.com NOTREECHECKS=true NOTRY=true BUG=327339 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164949

Patch Set 1 #

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -483 lines)			Patch
D	LayoutTests/svg/animations/discard-check-delete.svg	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-check-delete-expected.svg	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-check-removal-order.html	View	1 chunk	+0 lines, -40 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-check-removal-order-expected.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-on-discard.html	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-on-discard-expected.txt	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-on-svg-crash.html	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-on-svg-crash-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	LayoutTests/svg/animations/discard-rect-as-child.svg	View	1 chunk	+0 lines, -20 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-rect-as-child-expected.svg	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-rect-as-href.svg	View	1 chunk	+0 lines, -20 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-rect-as-href-expected.svg	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-rect-with-anim-child-a.svg	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-rect-with-anim-child-a-expected.svg	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-rect-with-anim-child-b.svg	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	LayoutTests/svg/animations/discard-rect-with-anim-child-b-expected.svg	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	LayoutTests/svg/animations/resources/discard-on-discard.svg	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	LayoutTests/svg/animations/script-tests/discard-on-discard.js	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	LayoutTests/svg/custom/global-constructors-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/svg/custom/script-tests/global-constructors.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/core.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	Source/core/svg/SVGDiscardElement.h	View	1 chunk	+0 lines, -59 lines	0 comments	Download
D	Source/core/svg/SVGDiscardElement.cpp	View	1 chunk	+0 lines, -61 lines	0 comments	Download
D	Source/core/svg/SVGDiscardElement.idl	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	Source/core/svg/SVGTagNames.in	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/animation/SMILTimeContainer.cpp	View	3 chunks	+4 lines, -22 lines	0 comments	Download
M	Source/core/svg/animation/SVGSMILElement.h	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/136313002/1

6 years, 11 months ago (2014-01-13 07:58:10 UTC) #2

alph

6 years, 11 months ago (2014-01-13 08:47:53 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/131683004/ by alph@chromium.org.

The reason for reverting is: The flaky test has been marked in
TestExpectations..

Expand Messages | Collapse Messages