ui/shell_dialogs/select_file_dialog_android.h - Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/shell_dialogs/select_file_dialog_android.h

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/shell_dialogs/select_file_dialog_android.h

diff --git a/ui/shell_dialogs/select_file_dialog_android.h b/ui/shell_dialogs/select_file_dialog_android.h

index 9aee3fd39311e1b7854a8a89cc3005dba404838c..53a17e8951ec2abbe0bf81709d0184ef1e1a3d52 100644

--- a/ui/shell_dialogs/select_file_dialog_android.h

+++ b/ui/shell_dialogs/select_file_dialog_android.h

@@ -50,6 +50,7 @@ class SelectFileDialogImpl : public SelectFileDialog {

protected:

~SelectFileDialogImpl() override;

+ void CloseImpl() override;

private:

SelectFileDialogImpl(Listener* listener, SelectFilePolicy* policy);

« ui/shell_dialogs/select_file_dialog.h ('K') | « ui/shell_dialogs/select_file_dialog.cc ('k') | ui/shell_dialogs/select_file_dialog_android.cc » ('j') | no next file with comments »