Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enable the test and skip libglib-2.0 from LSan report Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 6fa115c4624fc68d28f05b2ed52eab81389bc2e9..31f8c0f438c43cacbfc501c2d8047aa596a5cb83 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -885,7 +885,7 @@ void Browser::OverrideEncoding(int encoding_id) {
}
}
-void Browser::OpenFile() {
+ui::SelectFileDialog* Browser::OpenFile() {
content::RecordAction(UserMetricsAction("OpenFile"));
select_file_dialog_ = ui::SelectFileDialog::Create(
this, new ChromeSelectFilePolicy(
@@ -905,6 +905,7 @@ void Browser::OpenFile() {
base::FilePath::StringType(),
parent_window,
NULL);
+ return select_file_dialog_.get();
}
void Browser::UpdateDownloadShelfVisibility(bool visible) {

Powered by Google App Engine
This is Rietveld 408576698