chrome/browser/ui/browser.h - Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.h

Issue 1363093004: Add BrowserSelectFileDialogTest.OpenCloseFileDialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move the comment into the body of the function. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.h

diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h

index 460e9394bf3da574851bad02a7ea8fc525106d85..fb8de3a2a46a3fff0e8e96c4d263d2a6762d2aad 100644

--- a/chrome/browser/ui/browser.h

+++ b/chrome/browser/ui/browser.h

@@ -397,7 +397,7 @@ class Browser : public TabStripModelObserver,

void OverrideEncoding(int encoding_id);

// Show various bits of UI

- void OpenFile();

+ ui::SelectFileDialog* OpenFile();

sky 2015/10/30 15:31:17 Document ownership. That said, AFAICT all you want

joone 2015/10/30 15:59:59 Because this CL was separated from https://coderev

void UpdateDownloadShelfVisibility(bool visible);

« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »