Add BrowserSelectFileDialogTest.OpenCloseFileDialog

chrome/browser/ui/browser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_H_
 #define CHROME_BROWSER_UI_BROWSER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 379 matching lines @@
   // Returns true if the Browser can support the specified feature. See comment
   // in |SupportsWindowFeature| for details on this.
   bool CanSupportWindowFeature(WindowFeature feature) const;
 
   // TODO(port): port these, and re-merge the two function declaration lists.
   // Page-related commands.
   void ToggleEncodingAutoDetect();
   void OverrideEncoding(int encoding_id);
 
   // Show various bits of UI
-  void OpenFile();
+  ui::SelectFileDialog* OpenFile();

[sky, 2015/10/30 15:31:17]

Document ownership.
That said, AFAICT all you want to test is the open dialog, and only for gtk. Why
don't you have your test directly create the selectfiledialog and do the dance
you need to do to close it? That way no changes to browser and the like.

[joone, 2015/10/30 15:59:59]

Because this CL was separated from https://codereview.chromium.org/1233913009/
(Make file-picker modal on Linux)

This method was used in the CL and I was asked to add support for the
file-picker modal test for Windows ad CrOS.
https://codereview.chromium.org/1233913009/#msg35

 
   void UpdateDownloadShelfVisibility(bool visible);
 
   /////////////////////////////////////////////////////////////////////////////
 
   // Called by chrome::Navigate() when a navigation has occurred in a tab in
   // this Browser. Updates the UI for the start of this navigation.
   void UpdateUIForNavigationInTab(content::WebContents* contents,
                                   ui::PageTransition transition,
                                   bool user_initiated);
@@ skipping 573 matching lines @@
   // The following factory is used for chrome update coalescing.
   base::WeakPtrFactory<Browser> chrome_updater_factory_;
 
   // The following factory is used to close the frame at a later time.
   base::WeakPtrFactory<Browser> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Browser);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_H_