runtime/vm/thread.cc - Issue 1363033003: Make TimelineEventBlocks reclaimable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread.cc

Issue 1363033003: Make TimelineEventBlocks reclaimable (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/thread.cc

diff --git a/runtime/vm/thread.cc b/runtime/vm/thread.cc

index 79ccec8fa0f1a59a947cf8ec8314f2d2e42b01ec..8968f58a1e9d87184fc4090565f7d2be1ce198a9 100644

--- a/runtime/vm/thread.cc

+++ b/runtime/vm/thread.cc

@@ -344,6 +344,7 @@ bool Thread::IsThreadInterrupterEnabled(ThreadInterruptCallback* callback,

void Thread::CloseTimelineBlock() {

turnidge 2015/09/24 17:05:52 Close -> Reclaim? (Note from offfline discussion:

Cutch 2015/09/24 18:14:16 This was unused and is now removed.

+ MutexLocker ml(timeline_block_lock());

if (timeline_block() != NULL) {

timeline_block()->Finish();

set_timeline_block(NULL);