Make TimelineEventBlocks reclaimable

runtime/vm/thread.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/thread.h"
 
 #include "vm/growable_array.h"
 #include "vm/isolate.h"
 #include "vm/lockers.h"
 #include "vm/log.h"
@@ skipping 325 matching lines @@
 #endif
   ASSERT(callback != NULL);
   ASSERT(data != NULL);
   *callback = thread_interrupt_callback_;
   *data = thread_interrupt_data_;
   return (*callback != NULL) &&
          (*data != NULL);
 }
 
 
 void Thread::CloseTimelineBlock() {

[turnidge, 2015/09/24 17:05:52]

Close -> Reclaim?  (Note from offfline discussion: make sure this is still
used).

[Cutch, 2015/09/24 18:14:16]

This was unused and is now removed.

+  MutexLocker ml(timeline_block_lock());
   if (timeline_block() != NULL) {
     timeline_block()->Finish();
     set_timeline_block(NULL);
   }
 }
 
 
 bool Thread::CanLoadFromThread(const Object& object) {
 #define CHECK_OBJECT(type_name, member_name, expr, default_init_value)         \
   if (object.raw() == expr) return true;
@@ skipping 27 matching lines @@
     return Thread::name##_entry_point_offset();                                \
   }
 LEAF_RUNTIME_ENTRY_LIST(COMPUTE_OFFSET)
 #undef COMPUTE_OFFSET
 
   UNREACHABLE();
   return -1;
 }
 
 }  // namespace dart