Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1362863002: Merge to XFA: Add missing 'return' keyword. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
mdempsky
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add missing 'return' keyword. Discovered with experimental Clang plugin that flags temporary objects that are immediately destroyed. patch from issue 1359063003 at patchset 1 (http://crrev.com/1359063003#ps1) A=mdempsky@chromium.org TBR=mdempsky@chromium.org Review URL: https://codereview.chromium.org/1359103002 . (cherry picked from commit f316bfe37e2fc977376e18f7534aae9824da240a) Committed: https://pdfium.googlesource.com/pdfium/+/0244d40daf39caf97f47de9982f4aac88c0c8644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
TBR
5 years, 3 months ago (2015-09-23 01:28:36 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as 0244d40daf39caf97f47de9982f4aac88c0c8644 (presubmit successful).
5 years, 3 months ago (2015-09-23 01:28:46 UTC) #2
mdempsky
5 years, 3 months ago (2015-09-23 01:47:52 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698