Issue 1359103002: Add missing 'return' keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1359103002: Add missing 'return' keyword. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
mdempsky

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add missing 'return' keyword. Discovered with experimental Clang plugin that flags temporary objects that are immediately destroyed. patch from issue 1359063003 at patchset 1 (http://crrev.com/1359063003#ps1) A=mdempsky@chromium.org R=mdempsky@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f316bfe37e2fc977376e18f7534aae9824da240a

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	core/src/fxge/ge/fx_ge_fontmap.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

5 years, 3 months ago (2015-09-22 20:45:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f316bfe37e2fc977376e18f7534aae9824da240a (presubmit successful).