Notify NetworkDelegate when bytes have been sent over the network.

Notify NetworkDelegate when bytes have been sent over the network.

This CL adds and implements NetworkDelegate::OnNetworkBytesSent(), which
is used to notify the network delegate when bytes have been sent over
the network.

BUG=518051
Committed: https://crrev.com/28d558b8eb033054feddec53cfa667ac4652de0d
Cr-Commit-Position: refs/heads/master@{#351165}

[sclittle, 2015-09-24 21:13:32]

Patchset #1 (id:1) has been deleted

[sclittle, 2015-09-24 21:14:41]

sclittle@chromium.org changed reviewers:
+ bengr@chromium.org, mmenke@chromium.org

[sclittle, 2015-09-24 21:14:41]

PTAL

Thanks in advance.

[mmenke, 2015-09-24 21:30:24]

Looks good, just think method order should be changed.

https://codereview.chromium.org/1362793003/diff/20001/net/base/layered_networ...
File net/base/layered_network_delegate.cc (right):

https://codereview.chromium.org/1362793003/diff/20001/net/base/layered_networ...
net/base/layered_network_delegate.cc:108: int64_t bytes_sent) {}
Order here should match header order

https://codereview.chromium.org/1362793003/diff/20001/net/base/network_delega...
File net/base/network_delegate.h (right):

https://codereview.chromium.org/1362793003/diff/20001/net/base/network_delega...
net/base/network_delegate.h:81: void NotifyNetworkBytesSent(const URLRequest&
request, int64_t bytes_sent);
While I see you put this roughly in the order it's invoked, I think this method
makes more sense just above NotifyNetworkBytesReceived (Or below, for
consistency - I'm fine, either way).  This goes for all other files as well, and
OnNetworkBytesSent and NotifyNetworkBytesSentInternal as well.

[sclittle, 2015-09-24 22:20:43]

https://codereview.chromium.org/1362793003/diff/20001/net/base/layered_networ...
File net/base/layered_network_delegate.cc (right):

https://codereview.chromium.org/1362793003/diff/20001/net/base/layered_networ...
net/base/layered_network_delegate.cc:108: int64_t bytes_sent) {}
On 2015/09/24 21:30:24, mmenke wrote:
> Order here should match header order

Done.

https://codereview.chromium.org/1362793003/diff/20001/net/base/network_delega...
File net/base/network_delegate.h (right):

https://codereview.chromium.org/1362793003/diff/20001/net/base/network_delega...
net/base/network_delegate.h:81: void NotifyNetworkBytesSent(const URLRequest&
request, int64_t bytes_sent);
On 2015/09/24 21:30:24, mmenke wrote:
> While I see you put this roughly in the order it's invoked, I think this
method
> makes more sense just above NotifyNetworkBytesReceived (Or below, for
> consistency - I'm fine, either way).  This goes for all other files as well,
and
> OnNetworkBytesSent and NotifyNetworkBytesSentInternal as well.

Done.

[mmenke, 2015-09-28 04:27:14]

On 2015/09/24 22:20:43, sclittle wrote:
>
https://codereview.chromium.org/1362793003/diff/20001/net/base/layered_networ...
> File net/base/layered_network_delegate.cc (right):
> 
>
https://codereview.chromium.org/1362793003/diff/20001/net/base/layered_networ...
> net/base/layered_network_delegate.cc:108: int64_t bytes_sent) {}
> On 2015/09/24 21:30:24, mmenke wrote:
> > Order here should match header order
> 
> Done.
> 
>
https://codereview.chromium.org/1362793003/diff/20001/net/base/network_delega...
> File net/base/network_delegate.h (right):
> 
>
https://codereview.chromium.org/1362793003/diff/20001/net/base/network_delega...
> net/base/network_delegate.h:81: void NotifyNetworkBytesSent(const URLRequest&
> request, int64_t bytes_sent);
> On 2015/09/24 21:30:24, mmenke wrote:
> > While I see you put this roughly in the order it's invoked, I think this
> method
> > makes more sense just above NotifyNetworkBytesReceived (Or below, for
> > consistency - I'm fine, either way).  This goes for all other files as well,
> and
> > OnNetworkBytesSent and NotifyNetworkBytesSentInternal as well.
> 
> Done.

LGTM, sorry I forgot to sign off on this Friday.

[sclittle, 2015-09-28 19:46:57]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2015-09-28 19:48:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362793003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362793003/40001

[commit-bot: I haz the power, 2015-09-28 20:09:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 20:09:05]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sclittle, 2015-09-28 20:15:29]

The CQ bit was checked by sclittle@chromium.org

[sclittle, 2015-09-28 20:15:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1362793003/#ps60001
(title: "Rebased on master")

[commit-bot: I haz the power, 2015-09-28 20:15:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362793003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362793003/60001

[commit-bot: I haz the power, 2015-09-28 21:41:05]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-09-28 21:41:56]

Patchset 3 (id:??) landed as
https://crrev.com/28d558b8eb033054feddec53cfa667ac4652de0d
Cr-Commit-Position: refs/heads/master@{#351165}