Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: net/url_request/url_request_http_job_unittest.cc

Issue 1362793003: Notify NetworkDelegate when bytes have been sent over the network. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased on master Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/network_delegate_impl.cc ('k') | net/url_request/url_request_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job_unittest.cc
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc
index 43b7e2b73fbca3dda2b7c10e4dd8b7eea2ca008f..3ad193c61cfc142603cd0dd543852faf332550a9 100644
--- a/net/url_request/url_request_http_job_unittest.cc
+++ b/net/url_request/url_request_http_job_unittest.cc
@@ -149,6 +149,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
request->GetTotalSentBytes());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
request->GetTotalReceivedBytes());
+ EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)),
+ network_delegate_.total_network_bytes_sent());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
network_delegate_.total_network_bytes_received());
}
@@ -178,6 +180,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
request->GetTotalSentBytes());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
request->GetTotalReceivedBytes());
+ EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)),
+ network_delegate_.total_network_bytes_sent());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
network_delegate_.total_network_bytes_received());
}
@@ -209,6 +213,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest, TestContentLengthFailedRequest) {
request->GetTotalSentBytes());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
request->GetTotalReceivedBytes());
+ EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)),
+ network_delegate_.total_network_bytes_sent());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
network_delegate_.total_network_bytes_received());
}
@@ -241,6 +247,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
request->GetTotalSentBytes());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
request->GetTotalReceivedBytes());
+ EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)),
+ network_delegate_.total_network_bytes_sent());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
network_delegate_.total_network_bytes_received());
}
@@ -291,6 +299,9 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
EXPECT_EQ(CountReadBytes(final_reads, arraysize(final_reads)),
request->GetTotalReceivedBytes());
// Should include the redirect as well as the final response.
+ EXPECT_EQ(CountWriteBytes(redirect_writes, arraysize(redirect_writes)) +
+ CountWriteBytes(final_writes, arraysize(final_writes)),
+ network_delegate_.total_network_bytes_sent());
EXPECT_EQ(CountReadBytes(redirect_reads, arraysize(redirect_reads)) +
CountReadBytes(final_reads, arraysize(final_reads)),
network_delegate_.total_network_bytes_received());
@@ -320,6 +331,8 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest,
request->GetTotalSentBytes());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
request->GetTotalReceivedBytes());
+ EXPECT_EQ(CountWriteBytes(writes, arraysize(writes)),
+ network_delegate_.total_network_bytes_sent());
EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
network_delegate_.total_network_bytes_received());
}
« no previous file with comments | « net/base/network_delegate_impl.cc ('k') | net/url_request/url_request_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698