Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1362793002: Construct and check for mojo::Event's LocationData as needed. (Closed)

Created:
5 years, 3 months ago by msw
Modified:
5 years, 3 months ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Construct and check for mojo::Event's LocationData as needed. The location struct replaced |x| and |y| basic types by: https://codereview.chromium.org/1313353010 I audited pointer_data, wheel_data, and brush_data use too. BUG=534982 TEST=No crashes running view_manager_unittests locally. R=rjkroege@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/b143a367f667fa8608ab3286a74fc78fd704323d Cr-Commit-Position: refs/heads/master@{#350265}

Patch Set 1 #

Patch Set 2 : Also audit wheel_data and brush_data. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -67 lines) Patch
M components/html_viewer/blink_input_events_type_converters.cc View 1 3 chunks +43 lines, -37 lines 0 comments Download
M components/html_viewer/html_frame.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/touch_handler.cc View 1 2 chunks +18 lines, -11 lines 0 comments Download
M components/mus/event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gesture_manager.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M components/mus/gesture_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/view_tree_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 1 1 chunk +2 lines, -4 lines 1 comment Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 6 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
msw
Hey Robert, please take a look; thanks!
5 years, 3 months ago (2015-09-22 22:41:17 UTC) #1
rjkroege
lgtm https://codereview.chromium.org/1362793002/diff/20001/components/pdf_viewer/pdf_viewer.cc File components/pdf_viewer/pdf_viewer.cc (right): https://codereview.chromium.org/1362793002/diff/20001/components/pdf_viewer/pdf_viewer.cc#newcode388 components/pdf_viewer/pdf_viewer.cc:388: (event->wheel_data && event->wheel_data->delta_y < 0)) { my oops.
5 years, 3 months ago (2015-09-22 22:52:42 UTC) #2
msw
+TBR Scott for OWNERS; landing.
5 years, 3 months ago (2015-09-22 22:55:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362793002/20001
5 years, 3 months ago (2015-09-22 22:58:30 UTC) #6
sky
LGTM
5 years, 3 months ago (2015-09-22 23:04:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-22 23:45:23 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 23:46:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b143a367f667fa8608ab3286a74fc78fd704323d
Cr-Commit-Position: refs/heads/master@{#350265}

Powered by Google App Engine
This is Rietveld 408576698