components/pdf_viewer/pdf_viewer.cc - Issue 1362793002: Construct and check for mojo::Event's LocationData as needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/pdf_viewer/pdf_viewer.cc

Issue 1362793002: Construct and check for mojo::Event's LocationData as needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also audit wheel_data and brush_data. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/pdf_viewer/pdf_viewer.cc

diff --git a/components/pdf_viewer/pdf_viewer.cc b/components/pdf_viewer/pdf_viewer.cc

index f0a89cd230e0bcd19111f7f91c3c77598ba79271..a437f9c360b861bc60b48b5122c5c5f548e35334 100644

--- a/components/pdf_viewer/pdf_viewer.cc

+++ b/components/pdf_viewer/pdf_viewer.cc

@@ -385,16 +385,14 @@ class PDFView : public mojo::ApplicationDelegate,

// responsive to gesture events.

if ((event->key_data &&

event->key_data->windows_key_code == mojo::KEYBOARD_CODE_DOWN) ||

- (event->wheel_data && event->wheel_data &&

- event->wheel_data->delta_y < 0)) {

+ (event->wheel_data && event->wheel_data->delta_y < 0)) {

rjkroege 2015/09/22 22:52:41 my oops.

if (current_page_ < (page_count_ - 1)) {

current_page_++;

DrawBitmap(embedder_for_roots_[view]);

}

} else if ((event->key_data &&

event->key_data->windows_key_code == mojo::KEYBOARD_CODE_UP) ||

- (event->pointer_data && event->wheel_data &&

- event->wheel_data->delta_y > 0)) {

+ (event->wheel_data && event->wheel_data->delta_y > 0)) {

if (current_page_ > 0) {

current_page_--;

DrawBitmap(embedder_for_roots_[view]);

« no previous file with comments | « components/mus/view_tree_unittest.cc ('k') | mojo/converters/input_events/input_events_type_converters.cc » ('j') | no next file with comments »