Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 136273002: Revert 244383 "Use ContextProvider subclass to provide WGC3D poi..." (Closed)

Created:
6 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244383 "Use ContextProvider subclass to provide WGC3D poi..." Likely cause of WebGL conformance test crashes on Android GPU bot. BUG=333761, 181120 > Use ContextProvider subclass to provide WGC3D pointers > > Some cc::ContextProvider instances will also need to provide WebGraphicsContext3D* > interfaces to the underlying GL context, but not all. This adds a subclass of ContextProvider > in content:: to use for these users. The compositor itself doesn't need the WGC3D > accessor so it just uses the base class. > > BUG=181120 > > Review URL: https://codereview.chromium.org/126093010 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -141 lines) Patch
M trunk/src/content/browser/android/in_process/synchronous_compositor_factory_impl.h View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/content/common/gpu/client/context_provider_command_buffer.h View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/content/common/gpu/client/context_provider_command_buffer.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M trunk/src/content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/android/synchronous_compositor_factory.h View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/render_thread_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
D trunk/src/content/renderer/webgraphicscontext3d_provider_impl.h View 1 chunk +0 lines, -38 lines 0 comments Download
D trunk/src/content/renderer/webgraphicscontext3d_provider_impl.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M trunk/src/webkit/common/gpu/context_provider_in_process.h View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/webkit/common/gpu/context_provider_in_process.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D trunk/src/webkit/common/gpu/context_provider_web_context.h View 1 chunk +0 lines, -26 lines 0 comments Download
A + trunk/src/webkit/common/gpu/webgraphicscontext3d_provider_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/webkit/common/gpu/webgraphicscontext3d_provider_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/webkit/common/gpu/webkit_gpu.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 11 months ago (2014-01-13 07:20:00 UTC) #1
Ken Russell (switch to Gerrit)
6 years, 11 months ago (2014-01-13 07:21:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r244470.

Powered by Google App Engine
This is Rietveld 408576698