cc: Remove PicturePile and PicturePileImpl.

cc: Remove PicturePile and PicturePileImpl.

This patch removes the picture pile approach for recording and raster
sources. Most of the patch is to switch over the tests that were using
picture piles to use display list raster and recording sources.

BUG=533151
R=pdr, danakj, enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/85674026c1b01feca325692217e37dbedc1c10a8
Cr-Commit-Position: refs/heads/master@{#350414}

[vmpstr, 2015-09-22 18:46:33]

Please take a look. This might depend on a currently-reverted
https://codereview.chromium.org/1349913002/. I'll try and rebase.

[danakj, 2015-09-22 21:52:15]

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
File cc/layers/picture_layer_impl_unittest.cc (left):

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:2384: //
pending_tiling->CreateAllTilesForTesting();
heh oops *^_^*

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
File cc/layers/picture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:388: // Create an active recording
source, but make sure it's not solid.
this says make sure it's solid

but you then draw 2 rects, one that covers the layer and one that's skipping the
right/bottom row. can you comment on them to explain?

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:1651:
green_paint.setColor(SK_ColorGREEN);
can you comment why is green important? maybe in combination with
recorded_viewport != layer_bounds?

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:1718:
empty_recording->add_draw_rect_with_paint(gfx::Rect(layer_bounds), red_paint);
doesn't look so empty. solid_fill_recording?

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:4629: //
scoped_ptr<FakeDisplayListRecordingSource> partial_recording =
commented out code

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
File cc/output/renderer_pixeltest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2222: 1.f, blue_raster_source.get());
nit: no get()?

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2245: green_raster_source.get());
dittos

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2310: texture_format, viewport, 1.f,
white_raster_source.get());
dittos

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2380: texture_format, viewport, 1.f,
raster_source.get());
more dittos..

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2432: texture_format, viewport, 1.f,
raster_source.get());
D:

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2644: green_rect1, 1.f,
green_raster_source.get());
...

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2651: green_rect2, 1.f,
green_raster_source.get());
silly turn refptr into raw pointer into refptr..

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2722: content_union_rect, contents_scale,
raster_source.get());
but it sure is popular..

btw, you could also Pass() these raster_sources. Don't really matter cuz it's
tests, but just saying. It's pretty new, but rvalue_cast is fun amiright?

https://codereview.chromium.org/1362663002/diff/1/cc/playback/recording_sourc...
File cc/playback/recording_source_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/playback/recording_sourc...
cc/playback/recording_source_unittest.cc:16: scoped_ptr<T>
CreateRecordingSource(const gfx::Rect& viewport,
you can detemplatize this and have 1 function?

https://codereview.chromium.org/1362663002/diff/1/cc/playback/recording_sourc...
cc/playback/recording_source_unittest.cc:33: scoped_refptr<RasterSource>
CreateRasterSource(T* recording_source);
same?

https://codereview.chromium.org/1362663002/diff/1/cc/playback/recording_sourc...
cc/playback/recording_source_unittest.cc:50:
TYPED_TEST_CASE(RecordingSourceTest, RecordingSourceImplementations);
we don't need a TYPED_TEST_CASE anymore, and this whole thing could be renamed
to display_list_recording_source_unittest.cc and DLRSTest as the test suite?

https://codereview.chromium.org/1362663002/diff/1/cc/raster/tile_task_worker_...
File cc/raster/tile_task_worker_pool_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/raster/tile_task_worker_...
cc/raster/tile_task_worker_pool_unittest.cc:88: scoped_refptr<RasterSource>
picture_raster_source_;
nit: just raster_source_?

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
File cc/test/fake_display_list_raster_source.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
cc/test/fake_display_list_raster_source.cc:85: auto recording_source =
FakeDisplayListRecordingSource::CreateRecordingSource(
could we perhaps DCHECK that like

DCHECK_IMPLIES(!recorded_viewport.IsEmpty(),
gfx::Rect(size).Contains(recorded_viewport)) ?

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
cc/test/fake_display_list_raster_source.cc:143:
FakeDisplayListRasterSource::FakeDisplayListRasterSource()
do we need this constructor? it is not used?

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
File cc/test/fake_display_list_recording_source.h (right):

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
cc/test/fake_display_list_recording_source.h:51: scoped_refptr<RasterSource>
CreateRasterSource(
// DisplayListResourceSource overrides.

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
cc/test/fake_display_list_recording_source.h:113: bool
IsSuitableForGpuRasterization() const override;
move this up with the other override.

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling_unittest.cc:1791:
FakeDisplayListRasterSource::CreateFilled(layer_size);
before it was not filled (false), the test still works tho right?

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/tile_manager_unitt...
File cc/tiles/tile_manager_unittest.cc (left):

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/tile_manager_unitt...
cc/tiles/tile_manager_unittest.cc:934: gfx::Size tile_size(102, 102);
:D :D:D: D:D :D: :D :D :D :D :D :D :D :D:DDDDDDDDDDDDDD

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/tile_manager_unitt...
File cc/tiles/tile_manager_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/tile_manager_unitt...
cc/tiles/tile_manager_unittest.cc:1291: // TODO(vmpstr): Move these to LTHI
tests, since they can't create real
Hm, the bug says we don't get up a real resource provider. What is fake exactly?
I think you should be able to get these to work. If you need pixel output you
could change the output surface to software, but I don't think that's the
problem. The upload doesn't need to work (TestContextProvider should work).

Do you have a callstack or sometihng?

[vmpstr, 2015-09-22 22:57:50]

Please take a look.

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
File cc/layers/picture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:388: // Create an active recording
source, but make sure it's not solid.
On 2015/09/22 21:52:14, danakj wrote:
> this says make sure it's solid

It says make sure it's not solid.

> 
> but you then draw 2 rects, one that covers the layer and one that's skipping
the
> right/bottom row. can you comment on them to explain?

The important thing is that two rects are of different size, so the solid color
detection would say that the whole layer is not solid. Otherwise, it falls down
a path that isn't meant to be tested by this.

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:1651:
green_paint.setColor(SK_ColorGREEN);
On 2015/09/22 21:52:14, danakj wrote:
> can you comment why is green important? maybe in combination with
> recorded_viewport != layer_bounds?

I changed this to use CreatePartiallyFilled

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:1718:
empty_recording->add_draw_rect_with_paint(gfx::Rect(layer_bounds), red_paint);
On 2015/09/22 21:52:14, danakj wrote:
> doesn't look so empty. solid_fill_recording?

I changed this to use CreateFilledSolidColor

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:4629: //
scoped_ptr<FakeDisplayListRecordingSource> partial_recording =
On 2015/09/22 21:52:14, danakj wrote:
> commented out code

Removed.

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
File cc/output/renderer_pixeltest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2222: 1.f, blue_raster_source.get());
On 2015/09/22 21:52:15, danakj wrote:
> nit: no get()?

Changed to Pass.

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2245: green_raster_source.get());
On 2015/09/22 21:52:14, danakj wrote:
> dittos

Changed to Pass.

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2310: texture_format, viewport, 1.f,
white_raster_source.get());
On 2015/09/22 21:52:15, danakj wrote:
> dittos 

Changed to Pass.

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2380: texture_format, viewport, 1.f,
raster_source.get());
On 2015/09/22 21:52:15, danakj wrote:
> more dittos..

Changed to Pass.

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2432: texture_format, viewport, 1.f,
raster_source.get());
On 2015/09/22 21:52:15, danakj wrote:
> D:

Changed to Pass.

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2644: green_rect1, 1.f,
green_raster_source.get());
On 2015/09/22 21:52:15, danakj wrote:
> ...

Removed .get()

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2651: green_rect2, 1.f,
green_raster_source.get());
On 2015/09/22 21:52:15, danakj wrote:
> silly turn refptr into raw pointer into refptr..

Changed to Pass.

https://codereview.chromium.org/1362663002/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2722: content_union_rect, contents_scale,
raster_source.get());
On 2015/09/22 21:52:15, danakj wrote:
> but it sure is popular..
> 
> btw, you could also Pass() these raster_sources. Don't really matter cuz it's
> tests, but just saying. It's pretty new, but rvalue_cast is fun amiright?

Changed to Pass.

https://codereview.chromium.org/1362663002/diff/1/cc/playback/recording_sourc...
File cc/playback/recording_source_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/playback/recording_sourc...
cc/playback/recording_source_unittest.cc:16: scoped_ptr<T>
CreateRecordingSource(const gfx::Rect& viewport,
On 2015/09/22 21:52:15, danakj wrote:
> you can detemplatize this and have 1 function?

Done.

https://codereview.chromium.org/1362663002/diff/1/cc/playback/recording_sourc...
cc/playback/recording_source_unittest.cc:33: scoped_refptr<RasterSource>
CreateRasterSource(T* recording_source);
On 2015/09/22 21:52:15, danakj wrote:
> same?

Done.

https://codereview.chromium.org/1362663002/diff/1/cc/playback/recording_sourc...
cc/playback/recording_source_unittest.cc:50:
TYPED_TEST_CASE(RecordingSourceTest, RecordingSourceImplementations);
On 2015/09/22 21:52:15, danakj wrote:
> we don't need a TYPED_TEST_CASE anymore, and this whole thing could be renamed
> to display_list_recording_source_unittest.cc and DLRSTest as the test suite?

Incorporated this into the existing display_list_recording_source_unittest.cc

https://codereview.chromium.org/1362663002/diff/1/cc/raster/tile_task_worker_...
File cc/raster/tile_task_worker_pool_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/raster/tile_task_worker_...
cc/raster/tile_task_worker_pool_unittest.cc:88: scoped_refptr<RasterSource>
picture_raster_source_;
On 2015/09/22 21:52:15, danakj wrote:
> nit: just raster_source_?

Done.

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
File cc/test/fake_display_list_raster_source.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
cc/test/fake_display_list_raster_source.cc:85: auto recording_source =
FakeDisplayListRecordingSource::CreateRecordingSource(
On 2015/09/22 21:52:15, danakj wrote:
> could we perhaps DCHECK that like
> 
> DCHECK_IMPLIES(!recorded_viewport.IsEmpty(),
> gfx::Rect(size).Contains(recorded_viewport)) ?

Done.

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
cc/test/fake_display_list_raster_source.cc:143:
FakeDisplayListRasterSource::FakeDisplayListRasterSource()
On 2015/09/22 21:52:15, danakj wrote:
> do we need this constructor? it is not used?

Removed.

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
File cc/test/fake_display_list_recording_source.h (right):

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
cc/test/fake_display_list_recording_source.h:51: scoped_refptr<RasterSource>
CreateRasterSource(
On 2015/09/22 21:52:15, danakj wrote:
> // DisplayListResourceSource overrides.

Done.

https://codereview.chromium.org/1362663002/diff/1/cc/test/fake_display_list_r...
cc/test/fake_display_list_recording_source.h:113: bool
IsSuitableForGpuRasterization() const override;
On 2015/09/22 21:52:15, danakj wrote:
> move this up with the other override.

Done.

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling_unittest.cc:1791:
FakeDisplayListRasterSource::CreateFilled(layer_size);
On 2015/09/22 21:52:15, danakj wrote:
> before it was not filled (false), the test still works tho right?

I don't think it matters whether it's filled or not, it's testing coverage on
large numbers. I've changed this to empty.

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/tile_manager_unitt...
File cc/tiles/tile_manager_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/tile_manager_unitt...
cc/tiles/tile_manager_unittest.cc:1291: // TODO(vmpstr): Move these to LTHI
tests, since they can't create real
On 2015/09/22 21:52:15, danakj wrote:
> Hm, the bug says we don't get up a real resource provider. What is fake
exactly?
> I think you should be able to get these to work. If you need pixel output you
> could change the output surface to software, but I don't think that's the
> problem. The upload doesn't need to work (TestContextProvider should work).
> 

The bug is just a guess at what's going on here. I'm just hoping to punt these
tests to a follow up. The only difference is that previously a picture pile
would analyze tiles as solid, and the display list raster source does not. 

> Do you have a callstack or sometihng?

[ RUN      ] TileManagerTilePriorityQueueTest.SetIsLikelyToRequireADraw
Received signal 11 SEGV_MAPERR 000000000000
#0 0x7fba84ab204e base::debug::StackTrace::StackTrace()
#1 0x7fba84ab1b8f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fba822aa340 <unknown>
#3 0x7fba8505e87b cc::OneCopyTileTaskWorkerPool::PlaybackAndCopyOnWorkerThread()
#4 0x7fba850616de cc::(anonymous namespace)::RasterBufferImpl::Playback()
#5 0x7fba8511d019 cc::(anonymous namespace)::RasterTaskImpl::Raster()
#6 0x7fba8511c79c cc::(anonymous namespace)::RasterTaskImpl::RunOnWorkerThread()
#7 0x7fba8506ddfa cc::TaskGraphRunner::RunTaskWithLockAcquired()
#8 0x7fba8506d882 cc::TaskGraphRunner::Run()
#9 0x000000ecd135 cc::TestTaskGraphRunner::Run()
#10 0x7fba84be7bbf base::DelegateSimpleThread::Run()
#11 0x7fba84be7991 base::SimpleThread::ThreadMain()
#12 0x7fba84bd9d4a base::(anonymous namespace)::ThreadFunc()
#13 0x7fba822a2182 start_thread
#14 0x7fba81fcf47d clone
  r8: 0000000000000000  r9: c014d2cb5a509c00 r10: 0000000000000000 r11:
0000000000000001
 r12: 0000000000000000 r13: 0000000000000000 r14: c014d2cb5a509c00 r15:
00007fba7a344700
  di: 00007fba7a341c50  si: 00007fba7a341720  bp: 00007fba7a3428c0  bx:
00007fba7a341c58
  dx: 0000000000000000  ax: 0000000000000000  cx: 0000000000000000  sp:
00007fba7a341920
  ip: 00007fba8505e87b efl: 0000000000010202 cgf: 0000000000000033 erf:
0000000000000004
 trp: 000000000000000e msk: 00000000000

[danakj, 2015-09-22 23:04:06]

Thanks! LGTM

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
File cc/layers/picture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:388: // Create an active recording
source, but make sure it's not solid.
On 2015/09/22 22:57:49, vmpstr wrote:
> On 2015/09/22 21:52:14, danakj wrote:
> > this says make sure it's solid
> 
> It says make sure it's not solid.
> 
> > 
> > but you then draw 2 rects, one that covers the layer and one that's skipping
> the
> > right/bottom row. can you comment on them to explain?
> 
> The important thing is that two rects are of different size, so the solid
color
> detection would say that the whole layer is not solid. Otherwise, it falls
down
> a path that isn't meant to be tested by this.

Ya.. reading comprehension. All time low. Thanks :)

https://codereview.chromium.org/1362663002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl_unittest.cc:1718:
empty_recording->add_draw_rect_with_paint(gfx::Rect(layer_bounds), red_paint);
On 2015/09/22 22:57:49, vmpstr wrote:
> On 2015/09/22 21:52:14, danakj wrote:
> > doesn't look so empty. solid_fill_recording?
> 
> I changed this to use CreateFilledSolidColor

Nice.

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/tile_manager_unitt...
File cc/tiles/tile_manager_unittest.cc (right):

https://codereview.chromium.org/1362663002/diff/1/cc/tiles/tile_manager_unitt...
cc/tiles/tile_manager_unittest.cc:1291: // TODO(vmpstr): Move these to LTHI
tests, since they can't create real
On 2015/09/22 22:57:50, vmpstr wrote:
> On 2015/09/22 21:52:15, danakj wrote:
> > Hm, the bug says we don't get up a real resource provider. What is fake
> exactly?
> > I think you should be able to get these to work. If you need pixel output
you
> > could change the output surface to software, but I don't think that's the
> > problem. The upload doesn't need to work (TestContextProvider should work).
> > 
> 
> The bug is just a guess at what's going on here. I'm just hoping to punt these
> tests to a follow up. The only difference is that previously a picture pile
> would analyze tiles as solid, and the display list raster source does not. 
> 
> > Do you have a callstack or sometihng?
> 
> [ RUN      ] TileManagerTilePriorityQueueTest.SetIsLikelyToRequireADraw
> Received signal 11 SEGV_MAPERR 000000000000
> #0 0x7fba84ab204e base::debug::StackTrace::StackTrace()
> #1 0x7fba84ab1b8f base::debug::(anonymous namespace)::StackDumpSignalHandler()
> #2 0x7fba822aa340 <unknown>
> #3 0x7fba8505e87b
cc::OneCopyTileTaskWorkerPool::PlaybackAndCopyOnWorkerThread()
> #4 0x7fba850616de cc::(anonymous namespace)::RasterBufferImpl::Playback()
> #5 0x7fba8511d019 cc::(anonymous namespace)::RasterTaskImpl::Raster()
> #6 0x7fba8511c79c cc::(anonymous
namespace)::RasterTaskImpl::RunOnWorkerThread()
> #7 0x7fba8506ddfa cc::TaskGraphRunner::RunTaskWithLockAcquired()
> #8 0x7fba8506d882 cc::TaskGraphRunner::Run()
> #9 0x000000ecd135 cc::TestTaskGraphRunner::Run()
> #10 0x7fba84be7bbf base::DelegateSimpleThread::Run()
> #11 0x7fba84be7991 base::SimpleThread::ThreadMain()
> #12 0x7fba84bd9d4a base::(anonymous namespace)::ThreadFunc()
> #13 0x7fba822a2182 start_thread
> #14 0x7fba81fcf47d clone
>   r8: 0000000000000000  r9: c014d2cb5a509c00 r10: 0000000000000000 r11:
> 0000000000000001
>  r12: 0000000000000000 r13: 0000000000000000 r14: c014d2cb5a509c00 r15:
> 00007fba7a344700
>   di: 00007fba7a341c50  si: 00007fba7a341720  bp: 00007fba7a3428c0  bx:
> 00007fba7a341c58
>   dx: 0000000000000000  ax: 0000000000000000  cx: 0000000000000000  sp:
> 00007fba7a341920
>   ip: 00007fba8505e87b efl: 0000000000010202 cgf: 0000000000000033 erf:
> 0000000000000004
>  trp: 000000000000000e msk: 00000000000
> 
> 

OK follow up is fine, but I just don't expect that these will have to move
anywhere. Maybe we can just make them solid color anyway too?

[vmpstr, 2015-09-23 18:05:20]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 18:08:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362663002/20001

[commit-bot: I haz the power, 2015-09-23 19:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 19:07:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vmpstr, 2015-09-23 19:42:00]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-09-23 19:42:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362663002/20001

[commit-bot: I haz the power, 2015-09-23 20:39:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 20:39:05]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2015-09-23 20:53:54]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-09-23 20:54:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362663002/20001

[commit-bot: I haz the power, 2015-09-23 21:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 21:50:38]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2015-09-23 23:22:30]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-09-23 23:24:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362663002/20001

[commit-bot: I haz the power, 2015-09-24 00:25:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-24 00:35:25]

Patchset 2 (id:??) landed as
https://crrev.com/85674026c1b01feca325692217e37dbedc1c10a8
Cr-Commit-Position: refs/heads/master@{#350414}