cc: Remove PicturePile and PicturePileImpl.

cc/playback/recording_source_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "cc/playback/display_list_raster_source.h"
 #include "cc/test/fake_display_list_recording_source.h"
-#include "cc/test/fake_picture_pile.h"
-#include "cc/test/fake_picture_pile_impl.h"
 #include "cc/test/skia_common.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
 namespace {
 
 template <class T>
 scoped_ptr<T> CreateRecordingSource(const gfx::Rect& viewport,

[danakj, 2015/09/22 21:52:15]

you can detemplatize this and have 1 function?

[vmpstr, 2015/09/22 22:57:49]

Done.

                                     const gfx::Size& grid_cell_size);
 
 template <>
-scoped_ptr<FakePicturePile> CreateRecordingSource<FakePicturePile>(
-    const gfx::Rect& viewport,
-    const gfx::Size& grid_cell_size) {
-  return FakePicturePile::CreateFilledPile(grid_cell_size, viewport.size());
-}
-
-template <>
 scoped_ptr<FakeDisplayListRecordingSource> CreateRecordingSource<
     FakeDisplayListRecordingSource>(const gfx::Rect& viewport,
                                     const gfx::Size& grid_cell_size) {
   gfx::Rect layer_rect(viewport.right(), viewport.bottom());
   scoped_ptr<FakeDisplayListRecordingSource> recording_source =
       FakeDisplayListRecordingSource::CreateRecordingSource(viewport,
                                                             layer_rect.size());
   recording_source->SetGridCellSize(grid_cell_size);
 
   return recording_source.Pass();
 }
 
 template <class T>
 scoped_refptr<RasterSource> CreateRasterSource(T* recording_source);

[danakj, 2015/09/22 21:52:15]

same?

[vmpstr, 2015/09/22 22:57:49]

Done.

 
 template <>
 scoped_refptr<RasterSource> CreateRasterSource(
-    FakePicturePile* recording_source) {
-  return FakePicturePileImpl::CreateFromPile(recording_source, nullptr);
-}
-
-template <>
-scoped_refptr<RasterSource> CreateRasterSource(
     FakeDisplayListRecordingSource* recording_source) {
   bool can_use_lcd_text = true;
   return DisplayListRasterSource::CreateFromDisplayListRecordingSource(
       recording_source, can_use_lcd_text);
 }
 
 template <typename T>
 class RecordingSourceTest : public testing::Test {};
 
 using testing::Types;
 
-typedef Types<FakePicturePile, FakeDisplayListRecordingSource>
-    RecordingSourceImplementations;
+typedef Types<FakeDisplayListRecordingSource> RecordingSourceImplementations;
 
 TYPED_TEST_CASE(RecordingSourceTest, RecordingSourceImplementations);

[danakj, 2015/09/22 21:52:15]

we don't need a TYPED_TEST_CASE anymore, and this whole thing could be renamed
to display_list_recording_source_unittest.cc and DLRSTest as the test suite?

[vmpstr, 2015/09/22 22:57:49]

Incorporated this into the existing display_list_recording_source_unittest.cc

 
 TYPED_TEST(RecordingSourceTest, NoGatherImageEmptyImages) {
   gfx::Size grid_cell_size(128, 128);
   gfx::Rect recorded_viewport(0, 0, 256, 256);
 
   scoped_ptr<TypeParam> recording_source =
       CreateRecordingSource<TypeParam>(recorded_viewport, grid_cell_size);
   recording_source->SetGatherDiscardableImages(false);
   recording_source->Rerecord();
 
@@ skipping 252 matching lines @@
               gfx::SkRectToRectF(images[0].image_rect).ToString());
     EXPECT_EQ(gfx::RectF(260, 0, 128, 128).ToString(),
               gfx::SkRectToRectF(images[1].image_rect).ToString());
     EXPECT_EQ(gfx::RectF(260, 260, 128, 128).ToString(),
               gfx::SkRectToRectF(images[2].image_rect).ToString());
   }
 }
 
 }  // namespace
 }  // namespace cc