Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2216)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java

Issue 1362603002: Straighten up keyboard hide and show logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added a TODO and fixed test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java
index cfeebd9865dc2989ab8be75024128a4e83793777..0694de03af19c105cfb612c2e757a9f293c11951 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java
@@ -36,8 +36,7 @@ public class AdapterInputConnectionTest extends ContentShellTestBase {
launchContentShellWithUrl("about:blank");
assertTrue("Page failed to load", waitForActiveShellToBeDoneLoading());
mWrapper = new TestInputMethodManagerWrapper(getActivity());
- ImeAdapterDelegate delegate = new TestImeAdapterDelegate();
- mImeAdapter = new TestImeAdapter(mWrapper, delegate);
+ mImeAdapter = new TestImeAdapter(mWrapper, new TestImeAdapterDelegate());
mEditable = Editable.Factory.getInstance().newEditable("");
mConnection = new AdapterInputConnection(
getContentViewCore().getContainerView(), mImeAdapter, mEditable, new EditorInfo());
@@ -158,29 +157,6 @@ public class AdapterInputConnectionTest extends ContentShellTestBase {
}
}
- private static class TestImeAdapterDelegate implements ImeAdapterDelegate {
- @Override
- public void onImeEvent() {}
-
- @Override
- public void onKeyboardBoundsUnchanged() {}
-
- @Override
- public boolean performContextMenuAction(int id) {
- return false;
- }
-
- @Override
- public View getAttachedView() {
- return null;
- }
-
- @Override
- public ResultReceiver getNewShowKeyboardReceiver() {
- return null;
- }
- }
-
private static void assertCorrectState(String text, int selectionStart, int selectionEnd,
int compositionStart, int compositionEnd, ImeState actual) {
assertEquals("Text did not match", text, actual.text);

Powered by Google App Engine
This is Rietveld 408576698