content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java - Issue 1362603002: Straighten up keyboard hide and show logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

Issue 1362603002: Straighten up keyboard hide and show logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a TODO and fixed test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreInputConnectionTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

index 8ecc52edca7a2a1bff3f8100478228528ea93cf0..ff3bbebb81da52288253df45c7cd2b2d3eb54b9d 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

@@ -14,6 +14,9 @@ import android.view.MotionEvent;

import android.view.View;

import org.chromium.base.test.util.Feature;

+import org.chromium.content.browser.input.ImeAdapter;

+import org.chromium.content.browser.input.TestImeAdapterDelegate;

+import org.chromium.content.browser.test.util.TestInputMethodManagerWrapper;

import org.chromium.content_shell_apk.ContentShellTestBase;

/**

@@ -78,6 +81,9 @@ public class PopupZoomerTest extends ContentShellTestBase {

mPopupZoomer = createPopupZoomerForTest(getInstrumentation().getTargetContext());

mContentViewCore = new ContentViewCore(getActivity());

mContentViewCore.setPopupZoomerForTest(mPopupZoomer);

+ mContentViewCore.setImeAdapterForTest(new ImeAdapter(

+ new TestInputMethodManagerWrapper(mContentViewCore),

+ new TestImeAdapterDelegate()));

}

@SmallTest