Fix for "chrome://" links in PDFs.

extensions/browser/extension_web_contents_observer.cc

Index: extensions/browser/extension_web_contents_observer.cc
diff --git a/extensions/browser/extension_web_contents_observer.cc b/extensions/browser/extension_web_contents_observer.cc
index 187cfb22a95ead9a7d997d18aefe30ccd39cb71c..41c2dcfa1e62f5a74544472a0af3ccd771f256b7 100644
--- a/extensions/browser/extension_web_contents_observer.cc
+++ b/extensions/browser/extension_web_contents_observer.cc
@@ -77,19 +77,18 @@ void ExtensionWebContentsObserver::RenderViewCreated(
 
   content::RenderProcessHost* process = render_view_host->GetProcess();
 
-  // Some extensions use chrome:// URLs.
-  // This is a temporary solution. Replace it with access to chrome-static://
-  // once it is implemented. See: crbug.com/226927.
+  // Some extensions use "chrome://resources/" URLs.

[Charlie Reis, 2015/09/22 17:38:15]

Again, I'm not sure why this is handled separately from chrome://resources,
especially with a subtle check guarding each of them.  Seems easy for one check
to get modified without the other.

[paulmeyer, 2015/09/22 22:13:57]

See other comment. I'll move this out to the chrome layer.

   Manifest::Type type = extension->GetType();
   if (type == Manifest::TYPE_EXTENSION ||
       type == Manifest::TYPE_LEGACY_PACKAGED_APP ||
       (type == Manifest::TYPE_PLATFORM_APP &&
        extension->location() == Manifest::COMPONENT)) {
-    content::ChildProcessSecurityPolicy::GetInstance()->GrantScheme(
-        process->GetID(), content::kChromeUIScheme);
+    content::ChildProcessSecurityPolicy::GetInstance()->GrantSchemeHost(
+        process->GetID(), content::kChromeUIScheme,
+        content::kChromeUIResourcesHost);
   }
 
-  // Some extensions use file:// URLs.
+  // Some extensions use "file://" URLs.

[Charlie Reis, 2015/09/22 17:38:15]

nit: No need for quotes (or churn on this line).

[paulmeyer, 2015/09/22 22:13:57]

Done.

   if (type == Manifest::TYPE_EXTENSION ||
       type == Manifest::TYPE_LEGACY_PACKAGED_APP) {
     ExtensionPrefs* prefs = ExtensionPrefs::Get(browser_context_);