Fix for "chrome://" links in PDFs.

extensions/browser/extension_web_contents_observer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_web_contents_observer.h"
 
 #include "content/public/browser/child_process_security_policy.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
@@ skipping 59 matching lines @@
 
 void ExtensionWebContentsObserver::RenderViewCreated(
     content::RenderViewHost* render_view_host) {
   // TODO(devlin): Most/all of this should move to RenderFrameCreated.
   const Extension* extension = GetExtension(render_view_host);
   if (!extension)
     return;
 
   content::RenderProcessHost* process = render_view_host->GetProcess();
 
-  // Some extensions use chrome:// URLs.
-  // This is a temporary solution. Replace it with access to chrome-static://
-  // once it is implemented. See: crbug.com/226927.
+  // Some extensions use "chrome://resources/" URLs.

[Charlie Reis, 2015/09/22 17:38:15]

Again, I'm not sure why this is handled separately from chrome://resources,
especially with a subtle check guarding each of them.  Seems easy for one check
to get modified without the other.

[paulmeyer, 2015/09/22 22:13:57]

See other comment. I'll move this out to the chrome layer.

   Manifest::Type type = extension->GetType();
   if (type == Manifest::TYPE_EXTENSION ||
       type == Manifest::TYPE_LEGACY_PACKAGED_APP ||
       (type == Manifest::TYPE_PLATFORM_APP &&
        extension->location() == Manifest::COMPONENT)) {
-    content::ChildProcessSecurityPolicy::GetInstance()->GrantScheme(
-        process->GetID(), content::kChromeUIScheme);
+    content::ChildProcessSecurityPolicy::GetInstance()->GrantSchemeHost(
+        process->GetID(), content::kChromeUIScheme,
+        content::kChromeUIResourcesHost);
   }
 
-  // Some extensions use file:// URLs.
+  // Some extensions use "file://" URLs.

[Charlie Reis, 2015/09/22 17:38:15]

nit: No need for quotes (or churn on this line).

[paulmeyer, 2015/09/22 22:13:57]

Done.

   if (type == Manifest::TYPE_EXTENSION ||
       type == Manifest::TYPE_LEGACY_PACKAGED_APP) {
     ExtensionPrefs* prefs = ExtensionPrefs::Get(browser_context_);
     if (prefs->AllowFileAccess(extension->id())) {
       content::ChildProcessSecurityPolicy::GetInstance()->GrantScheme(
           process->GetID(), url::kFileScheme);
     }
   }
 
   // Tells the new view that it's hosted in an extension process.
@@ skipping 105 matching lines @@
   // Since this is called for all existing RenderFrameHosts during the
   // ExtensionWebContentsObserver's creation, it's possible that not all hosts
   // are ready.
   // We only initialize the frame if the renderer counterpart is live; otherwise
   // we wait for the RenderFrameCreated notification.
   if (render_frame_host->IsRenderFrameLive())
     InitializeRenderFrame(render_frame_host);
 }
 
 }  // namespace extensions