chrome/browser/resources/chromeos/chromevox/common/time_widget.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/time_widget.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/page_selection.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/common/time_widget.js

diff --git a/chrome/browser/resources/chromeos/chromevox/common/time_widget.js b/chrome/browser/resources/chromeos/chromevox/common/time_widget.js

index 869189d6db4b34c4968c98cd5f3ac3af6742245b..8691d63fb85b67c14e6bd6f905951e48d8e8f15a 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/time_widget.js

+++ b/chrome/browser/resources/chromeos/chromevox/common/time_widget.js

@@ -136,7 +136,7 @@ cvox.ChromeVoxHTMLTimeWidget.prototype.update_ = function(shouldSpeakLabel) {

var minutes = -1;

var seconds = 0;

var milliseconds = 0;

- var ampm = cvox.ChromeVox.msgs.getMsg('timewidget_am');

+ var ampm = Msgs.getMsg('timewidget_am');

if (splitTime.length > 1) {

minutes = splitTime[1];

}

@@ -149,14 +149,14 @@ cvox.ChromeVoxHTMLTimeWidget.prototype.update_ = function(shouldSpeakLabel) {

}

if (hours > 12) {

hours = hours - 12;

- ampm = cvox.ChromeVox.msgs.getMsg('timewidget_pm');

+ ampm = Msgs.getMsg('timewidget_pm');

}

if (hours == 12) {

- ampm = cvox.ChromeVox.msgs.getMsg('timewidget_pm');

+ ampm = Msgs.getMsg('timewidget_pm');

}

if (hours == 0) {

hours = 12;

- ampm = cvox.ChromeVox.msgs.getMsg('timewidget_am');

+ ampm = Msgs.getMsg('timewidget_am');

}

var changeMessage = '';

@@ -167,25 +167,25 @@ cvox.ChromeVoxHTMLTimeWidget.prototype.update_ = function(shouldSpeakLabel) {

if (hours != this.pHours_) {

changeMessage = changeMessage + hours + ' ' +

- cvox.ChromeVox.msgs.getMsg('timewidget_hours') + '\n';

+ Msgs.getMsg('timewidget_hours') + '\n';

this.pHours_ = hours;

}

if (minutes != this.pMinutes_) {

changeMessage = changeMessage + minutes + ' ' +

- cvox.ChromeVox.msgs.getMsg('timewidget_minutes') + '\n';

+ Msgs.getMsg('timewidget_minutes') + '\n';

this.pMinutes_ = minutes;

}

if (seconds != this.pSeconds_) {

changeMessage = changeMessage + seconds + ' ' +

- cvox.ChromeVox.msgs.getMsg('timewidget_seconds') + '\n';

+ Msgs.getMsg('timewidget_seconds') + '\n';

this.pSeconds_ = seconds;

}

if (milliseconds != this.pMilliseconds_) {

changeMessage = changeMessage + milliseconds + ' ' +

- cvox.ChromeVox.msgs.getMsg('timewidget_milliseconds') + '\n';

+ Msgs.getMsg('timewidget_milliseconds') + '\n';

this.pMilliseconds_ = milliseconds;

}